Re: [Monotone-devel] git fast-export

[Felipe Contreras]

On Tue, Feb 10, 2009 at 1:40 AM, Felipe Contreras
<address@hidden> wrote:
> On Sun, Jan 25, 2009 at 6:40 AM, Derek Scherger <address@hidden> wrote:
>> On Thu, Jan 22, 2009 at 1:33 PM, Derek Scherger <address@hidden> wrote:
>>>
>>>> I think "<unknown>" is a better start point.
>>
>> Both committer and author are defaulted to "<unknown>" in rev
>> 2c207d528e37e59d8d8d14e24edd14fb34a10a21.
>>
>> I'm using the value from the author cert as the git author and the key from
>> the same cert as the git committer. That should generally be the same key
>> that would be on a changelog cert but it's not guaranteed to be.
>>
>> I've also removed the code that was trying to clean up various things, like
>> adding < and > around email addresses. These should all be fixed by mappings
>> using the --authors-file now.
>>
>> The list of committers that might need mapping comes from:
>>
>> $ mtn db execute 'select distinct keypair from revision_certs where name =
>> "author"'
>>
>> The list of authors that might need mapping comes from:
>>
>> $ mtn db execute 'select distinct value from revision_certs where name =
>> "author"'
>
> Great!
>
> I'm getting a bit further now, but I'm still having some
> incompatibilities. I've tried to emulate most of them, but it takes
> time between each try.
>
> The first issue I stumbled upon is that you do the following:
>
>      db.get_revision_certs(*r, author_cert_name, authors);
>      db.get_revision_certs(*r, branch_cert_name, branches);
>      db.get_revision_certs(*r, changelog_cert_name, changelogs);
>      db.get_revision_certs(*r, comment_cert_name, comments);
>      db.get_revision_certs(*r, date_cert_name, dates);
>
> While I get all the certs and handle them in one single go. I think
> it's more efficient to do a single sql query. This generates a
> different order when there's multiple committers. For now I'm doing it
> separately as your code does.
>
> The next one is regarding the changelogs. I want to have only one
> changelog, not concatenate them. So I patched your code. I'm attaching
> the patch.
>
> Then I tried to update to your latest revision and I'm getting a
> failure from fast import. I'm attaching the report.

Ah, I read your comments in the code, so it fails when the author is
not defined... I think that should be optional.

How about this patch?

-- 
Felipe Contreras

mtn-fast-export-authors.diff
Description: Binary data