[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Monotone-devel] Kicking around ideas
From: |
Stephen Leake |
Subject: |
Re: [Monotone-devel] Kicking around ideas |
Date: |
Thu, 24 Jan 2008 02:20:55 -0500 |
User-agent: |
Gnus/5.1006 (Gnus v5.10.6) Emacs/22.1 (windows-nt) |
Thomas Keller <address@hidden> writes:
>>> I haven't yet propagated from mainline, so I guess there will be a
>>> conflict wrt the recent tests Stephe added (I implemented them as well
>>> on my branch) - if I fix that, is it ok if I merge nvm.inventory-fixes
>>> to mainline?
>>
>> I see you have now propagated from mainline.
>>
>> I like the new option --no-corresponding-renames.
>>
>> I'm getting a test failure:
>>
>> 78 automate_inventory_options FAIL (line 13)
>>
>> all of the "expected-renames-*.stdout" files are missing.
>>
>> I assume this passes on your system.
>
> Yes, sorry, added them in ce4ffef538886e199240be25c2433c1ebf1b4cad
Ok, now all automate_inventory tests pass on my system.
>> I don't see an explicit test of --no-unchanged with added/dropped
>> nodes (there is one with renames). I can work on adding those tests,
>> after the merge.
>
> There are a couple of other open tests at the end of
> automate_inventory/__driver__.lua, if you are in the mood, it would be
> cool if you could add those as well. F.e. the test to verify the
> "invalid" state is completly missing.
Right.
> I've updated monotone.texi with some new examples already and
> rewrote / improved some parts,
Yes, that looks good.
> so the tests are the only thing missing for this now.
Right.
--
-- Stephe
- Re: [Monotone-devel] Kicking around ideas, (continued)
Re: [Monotone-devel] Kicking around ideas, Thomas Keller, 2008/01/22