On Thu, Jan 17, 2008 at 07:40:09PM +1100, William Uther wrote:
I'm not sure if that should be committed or not. It reduces 'time ls
branches --ignore-suspend-certs' on my monotone db from 7s down to
less than 0.1s. But it means ignoring the validity of certs in this
case.
I am doubtful that anyone cares if 'ls branches' might include branch
names that only exist in invalid certs -- at the moment, there isn't
even any sane way to *have* invalid certs. I don't care, myself, and
am perfectly happy to leave it broken until a user actually notices.
If one really does want to get 'ls branches' exactly correct in that
case, the right way isn't to do expensive head-calculation anyway.
All we need to know is that there is some valid branch cert out there
somewhere, and we can tell that by just pulling a cert out of the db
and checking it, which is very cheap.