RE: [Monotone-devel] New monotone buildbot, slaves desired

[Kelly F. Hickel]

> -----Original Message-----
> From: Markus Schiltknecht [mailto:address@hidden
> Sent: Tuesday, July 10, 2007 6:46 AM
> To: Kelly F. Hickel
> Cc: Richard Levitte; address@hidden
> Subject: Re: [Monotone-devel] New monotone buildbot, slaves desired
> 
> Hello Kelly,
> 
> Kelly F. Hickel wrote:
> >     Regarding the instructions on the wiki, there's a patch
> > mentioned but when I look at the recent email that the patch link
> leads
> > to, I can't find any of the lines that the emails say need to be
> > changed.  I've installed buildbot v0.7.5, is that the correct
> version?
> 
> Sorry if that was unclear. You just need to apply the patch to
buildbot
> v0.7.5 (or CVS HEAD). All the changes discussed in the recent emails
> (up
> until now) are incorporated into that very patch, which I hope is
going
> into buildbot mainline, soon.
> 
> Markus

Hi Markus,
        OK, so, I'm really confused.

The patch link under discussion is this:
http://sourceforge.net/mailarchive/forum.php?thread_name=46933C73.503070
5%40bluegap.ch&forum_name=buildbot-devel

Where it says: 
> Small point: in monotone.py, you've added '"--last", "20"' just before
> the addition of depth_arg. A bit unnecessary, wouldn't you say?

So, in my buildbot 0.7.5 install, I find two copies of monoton.py:
address@hidden buildbot-0.7.5]# !find
find . -name mono\* -print
./buildbot/changes/monotone.py
./build/lib/buildbot/changes/monotone.py

Those (identical as expected) files only contain a single line with the
text "--last", and it doesn't contain the text "20":

    def log(self, rev, depth=None):
        if depth is not None:
            depth_arg = ["--last=%i" % (depth,)]
        else:
            depth_arg = []
        return self._run_monotone(["log", "-r", rev] + depth_arg)


So, is a change needed or not?  It's not obvious to me.


-Kelly