Re: [Monotone-devel] Call for testing: nvm.experiment.no-split-path

[Timothy Brownawell]

On Wed, 2007-06-27 at 17:03 -0700, Zack Weinberg wrote:
> On 6/22/07, Derek Scherger <address@hidden> wrote:

> > The profiles I have do seem to be pretty consistent in showing the
> > dir_map lookups at or near the top at around 8-10% of the total time. I
> > think Tim changed this to a "hybrid_map" but it seems like there still
> > may be room for improvement there.
> 
> The hybrid_map is for roster_t::nodes, not for dir_t::children.
> Having O(1) lookup in dir_t::children would definitely help, but I'm
> not sure a hybrid_map is the right way to do it (to be honest though,
> I don't know what the right way *is* ... maybe, like, steal the
> directory htrees from ext3fs).

I tried that, and it actually seemed to slow things down a bit (for
pull, at least). Probably because we don't actually *do* lookups that
often, I think mostly we just iterate through everything. So the bigger
effect is the higher overhead of inserting into the map, since you now
have two indexes to maintain. Maybe a trie or something would work?


-- 
Timothy

Free (experimental) public monotone hosting: http://mtn-host.prjek.net