[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] Re: [Monotone-commits-diffs] Revision eeef5ff823a54c2a6
From: |
Richard Levitte - VMS Whacker |
Subject: |
[Monotone-devel] Re: [Monotone-commits-diffs] Revision eeef5ff823a54c2a678d40da6f658881679b809b |
Date: |
Wed, 31 Aug 2005 08:16:02 +0200 (CEST) |
I like the change to incremental binary checking, but I've a small
issue with the new name of the function; I sure hope that the
*filename* would be text most of the times.
Can I request a name change to "guess_binary_file"?
In message <address@hidden> on Wed, 31 Aug 2005 04:05:02 UT, address@hidden
said:
monotone> -----------------------------------------------------------------
monotone> Revision: eeef5ff823a54c2a678d40da6f658881679b809b
monotone> Ancestor: d4b21f39fde5e04513baa94b0336b7701aabf745
monotone> Author: Eric Anderson <address@hidden>
monotone> Date: 2005-08-31T03:10:57
monotone> Branch: net.venge.monotone
[...]
monotone>
========================================================================
monotone> --- lua.cc 60a450c0fcb35a460fdfe3a6fe4d74b5dd9612e0
monotone> +++ lua.cc 289aa9474f82e484b42a4db7f6280c4c6d33c088
[...]
monotone> static int
monotone> - monotone_guess_binary_for_lua(lua_State *L)
monotone> + monotone_guess_binary_filename_for_lua(lua_State *L)
[...]
monotone> @@ -600,7 +622,7 @@
monotone> lua_register(st, "wait", monotone_wait_for_lua);
monotone> lua_register(st, "kill", monotone_kill_for_lua);
monotone> lua_register(st, "sleep", monotone_sleep_for_lua);
monotone> - lua_register(st, "guess_binary", monotone_guess_binary_for_lua);
monotone> + lua_register(st, "guess_binary_filename",
monotone_guess_binary_filename_for_lua);
monotone> lua_register(st, "include", monotone_include_for_lua);
monotone> lua_register(st, "includedir", monotone_includedir_for_lua);
monotone> }
Cheers,
Richard
--
Richard Levitte address@hidden
http://richard.levitte.org/
"When I became a man I put away childish things, including
the fear of childishness and the desire to be very grown up."
-- C.S. Lewis
- [Monotone-devel] Re: [Monotone-commits-diffs] Revision eeef5ff823a54c2a678d40da6f658881679b809b,
Richard Levitte - VMS Whacker <=