[Monotone-devel] popt is now bundled and corrected.

[Richard Levitte - VMS Whacker]

I've now bundled popt with monotone.  It was needed, at least for the
moment, because popt 1.7 (the current version out there) has so serious
memory allocation and buffer overflow bugs when poptStuffArgs() is
used.

I've tagged the revision that contains the *original* popt (as
distributed by Debian) with 'popt-1.7', then patched it up with my
fixes.  This is to make it easy for us to just make a diff against the
tag to show others what fixes are needed.

The restriction of using -@ only once is now lifted, and the test show
that it works beautifully.  A run with contrib/Notify.pl (it makes
good use of -@) shows further that the buffer overflows problem with
leftovers is gone.

I've tried to check if there is anything else that might be affected
in similar ways by the use of poptStuffArgs(), but couldn't find any.
I welcome anyone else to double-check.

Cheers,
Richard

-----
Please consider sponsoring my work on free software.
See http://www.free.lp.se/sponsoring.html for details.

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"When I became a man I put away childish things, including
 the fear of childishness and the desire to be very grown up."
                                                -- C.S. Lewis