monotone-debian
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Monotone-debian] Review, please?


From: Richard Levitte
Subject: Re: [Monotone-debian] Review, please?
Date: Sat, 16 Apr 2011 16:26:33 +0200 (CEST)

In message <address@hidden> on Sat, 16 Apr 2011 14:55:21 +0100, Francis Russell 
<address@hidden> said:

francis> Richard Levitte wrote:
francis> 
francis> > I'm not sure about the find solution.  However, it seems to me that 
if
francis> > /var/run/monotone still exists for some reason, the monotone user and
francis> > group shouldn't be removed, just like if /var/lib/monotone still
francis> > exists.  I've made a change for that and pushed it moments ago, see
francis> > revision 1fae06279d7da2329c2596e09422e8b2517b5cfa.
francis> 
francis> So, the monotone user and group also owns /etc/monotone and
francis> /var/log/monotone. I've just pushed a new commit that should handle
francis> refusing to delete the monotone user/group if any of these exist and
francis> give a clearer reason why (although dpkg will also show warnings for
francis> folders it can't remove). This also requires handling of the attempted
francis> deletion of /etc/monotone{,hooks.d} in the postrm script.

Makes sense.  I'm going to make a build+lintian, just to make sure
nothing's missed.  If it goes through, I'd say we have something
workable.

francis> I wasn't quite sure what to do about the Debian changelog
francis> entry.

Maybe rewrite it a bit.

francis> Did you see my comments on the bash completion issue?

Yes.  As you said, this isn't a Debian issue.  I'll address that
later.

Cheers,
Richard

-- 
Richard Levitte                         address@hidden
                                        http://richard.levitte.org/

"Life is a tremendous celebration - and I'm invited!"
-- from a friend's blog, translated from Swedish



reply via email to

[Prev in Thread] Current Thread [Next in Thread]