[Monotone-debian] Bug#542287: monotone-server: Incorrect runlevels and dependencies in init.d script

[Petter Reinholdtsen]

Package:  monotone-server
Version:  0.43-1
Severity: important
Tags:     patch
User:     address@hidden
Usertags: incorrect-runlevels incorrect-dependency

With dependency based boot sequencing, I discovered what I believe is
a bug in the init.d script.  The provides should be unique and
preferably the name of the script.  The current one conflict do not
with the any script, but I wanted to mention it.  The script need
/usr/, and should depend on $remote_fs.  The script used to start
after syslog, so I suggest making it depend on $syslog.  Also the
runlevel list do not match the arguments to update-rc.d, it should
start in runlevel 2.

<URL: 
http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html
 >
documents the LSB header format.  Some debian notes are available from
<URL: http://wiki.debian.org/LSBInitScripts >.

This patch should solve the issue.  Without it, the script will fail
to start in runlevels 2, and might start to early.  In addition to
this header change, some code in postinst is needed to remove the stop
symlink in rc2.d and add a start symlink in rc2.d during upgrades.

diff -ur monotone-0.44/debian/monotone-server.monotone.init 
monotone-0.44-pere/debian/monotone-server.monotone.init
--- monotone-0.44/debian/monotone-server.monotone.init  2009-08-18 
21:57:31.000000000 +0200
+++ monotone-0.44-pere/debian/monotone-server.monotone.init     2009-08-18 
22:00:12.000000000 +0200
@@ -6,10 +6,10 @@
 #
 ### BEGIN INIT INFO
 # Provides: monotone
-# Required-Start: $network $local_fs
-# Required-Stop: $network $local_fs
-# Default-Start: 3 4 5
-# Default-Stop: 0 1 2 6
+# Required-Start: $network $remote_fs $syslog
+# Required-Stop:  $network $remote_fs $syslog
+# Default-Start:  2 3 4 5
+# Default-Stop:   0 1 6
 # Short-Description: Monotone server.
 ### END INIT INFO


Happy hacking,
-- 
Petter Reinholdtsen