Re: patch to add a disable-strip option (i.e.: while crosscompileing )

[Claus Klein]

Ok, but than is my patch the right one.

Default it would be like it was, strip on install.
For people like me, we can control it with 
 ./configure --disable-strip
And it is documented too; Try 
 ./configure --help

claus

On Saturday 26 March 2005 21:48, Jan-Henrik Haukeland wrote:
> I don't think it should be necessary to remove stripping of the binary  
> on install. In those very few cases when a non-stripped version is  
> needed (i.e. for producing meaningful tracebacks from a core file), the  
> user can simply build monit and install manually.
> 
> 
> On Mar 26, 2005, at 8:46, Martin Pala wrote:
> 
> > Here is patch for makefile install-debug target, if you agree, i can  
> > send it to cvs (when i'll be back from holiday ;)
> >
> > Martin
> >
> > P.S. Happy Easter :)
> >
> >
> >
> > Claus Klein wrote:
> >> I think there are more than one solutions for the little problem:
> >>  "How to prevent host stripping while 'make install' in a cross  
> >> development environment?"
> >> It would be also possible and a goot idea to have an option which  
> >> strip program is used
> >> while installation step.
> >> For me this was the clean solution for my problem.
> >> I found it in the openssh-3.9p1 configure program, which has the same  
> >> option.
> >> What do you mean about the:
> >>  LEXFLAGS = -i --noyywrap
> >> Without this, I had an unresolved symblol in buildroot environment  
> >> with ulibc.
> >> Claus
> >> On Friday 25 March 2005 09:11, Martin Pala wrote:
> >>> Maybe it could be sufficient to add for example 'installdebug'  
> >>> target to the makefile?
> >>>
> >>> This allows to have common configuration section - the decision is  
> >>> made by choosing appropriate install method (both are possible  
> >>> without reconfiguring monit).
> >>>
> >>> Martin
> >>>
> >>>
> >>> Claus Klein wrote:
> >>>
> >>>
> >>>> Hi
> >>>>
> >>>> I send a little patch to support crosscompileing with buildroot.
> >>>> configure my be used with a new option:
> >>>> --disable-strip         Disable calling strip(1) on install
> >>>>
> >>>> Too I had a little problem while linking with ulibc under buildroot.
> >>>> So I changed the default value in Makefile.am to: LEXFLAGS = -i  
> >>>> --noyywrap
> >>>> Perhaps this should be configurable too?
> >>>>
> >>>> See too http://buildroot.uclibc.org/
> >>>>
> >>>> claus
> >>>>
> >>>>
> >>>>
> >>>> -------------------------------------------------------------------- 
> >>>> ----
> >>>>
> >>>> diff -Naur monit-4.4-dist/Makefile.in monit-4.4/Makefile.in
> >>>> --- monit-4.4-dist/Makefile.in 2004-01-29 17:52:11.000000000 +0000
> >>>> +++ monit-4.4/Makefile.in 2005-03-20 21:43:34.000000000 +0000
> >>>> @@ -39,7 +39,8 @@
> >>>> MODE_DIRS       = 755
> >>>> INSTALL         = @INSTALL@ -INSTALL_PROG    = $(INSTALL) -m  
> >>>> $(MODE_PROGS) -s
> >>>> +STRIP_OPT       = @STRIP_OPT@
> >>>> +INSTALL_PROG    = $(INSTALL) -m $(MODE_PROGS) $(STRIP_OPT)
> >>>> INSTALL_FILE    = $(INSTALL) -m $(MODE_FILES)
> >>>> INSTALL_DIR     = $(INSTALL) -m $(MODE_DIRS) -d
> >>>> @@ -70,7 +71,7 @@
> >>>> LINKFLAGS = @LDFLAGS@
> >>>> CFLAGS  = @CFLAGS@ $(DEFINES) @CPPFLAGS@ $(INCDIR)
> >>>> -LEXFLAGS = -i
> >>>> +LEXFLAGS = -i --noyywrap
> >>>> YACCFLAGS  = -dt
> >>>> #  
> >>>> -------------------------------------------------------------------  
> >>>> #
> >>>> diff -Naur monit-4.4-dist/configure.ac monit-4.4/configure.ac
> >>>> --- monit-4.4-dist/configure.ac 2004-09-23 18:59:52.000000000 +0000
> >>>> +++ monit-4.4/configure.ac 2005-03-20 21:54:46.000000000 +0000
> >>>> @@ -404,6 +404,23 @@
> >>>> AC_SUBST(ARCH)
> >>>> #  
> >>>> -------------------------------------------------------------------- 
> >>>> ----
> >>>> +# disable-strip option (i.e.: while crosscompileing)
> >>>> +#  
> >>>> -------------------------------------------------------------------- 
> >>>> ----
> >>>> +
> >>>> +STRIP_OPT=-s
> >>>> +# Check if we want to disable call strip on install
> >>>> +AC_ARG_ENABLE(strip,
> >>>> + [  --disable-strip         Disable calling strip(1) on install],
> >>>> + [
> >>>> +  if test "x$enableval" = "xno" ; then
> >>>> +                        STRIP_OPT=
> >>>> +                fi
> >>>> +        ]
> >>>> +)
> >>>> +AC_SUBST(STRIP_OPT)
> >>>> +
> >>>> +
> >>>> +#  
> >>>> -------------------------------------------------------------------- 
> >>>> ----
> >>>> # Resource code
> >>>> #  
> >>>> -------------------------------------------------------------------- 
> >>>> ----
> >>>>
> >>>>
> >>>> -------------------------------------------------------------------- 
> >>>> ----
> >>>>
> >>>> --
> >>>> To unsubscribe:
> >>>> http://lists.nongnu.org/mailman/listinfo/monit-general
> >>>
> >>>
> >>>
> >>> --
> >>> To unsubscribe:
> >>> http://lists.nongnu.org/mailman/listinfo/monit-general
> >>>
> >> --
> >> To unsubscribe:
> >> http://lists.nongnu.org/mailman/listinfo/monit-general
> > <install.patch>_______________________________________________
> > monit-dev mailing list
> > address@hidden
> > http://lists.nongnu.org/mailman/listinfo/monit-dev
> >
> --
> Jan-Henrik Haukeland
> Mobil +47 97141255
> 
> 
> 
> _______________________________________________
> monit-dev mailing list
> address@hidden
> http://lists.nongnu.org/mailman/listinfo/monit-dev
>