[Mldonkey-bugs] [bug #14468] max_hard_upload_rate erratic behavior (load sensitive)

[pango]

Follow-up Comment #6, bug #14468 (project mldonkey):

Ok, I think I've found a bug in bittorrent upload handler (I don't use
bittorrent, so I missed it before).
Since this support tries to send data in bigger chunks than what the upload
scheduler usually allows in one turn, it maintains its own credit
accumulators internally (one per connection).
However, main credits are decremented twice, once when they're transfered to
private accumulators, and once when data is sent.

The quick fix is to remove the call to consume_bandwidth when data is sent.

That's only a quick fix however. Keeping a private accumulator per client
means that the bittorrent support can generate big overshots. And with a
single accumulator, it will be difficult to be fair within clients of the
same network, since the upload scheduler forces a client rotation before each
call. Maybe each network support should have its own Fifo of upload slots...
(?)


    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14468>

_______________________________________________
  Message posté via/par Savannah
  http://savannah.nongnu.org/