[Mldonkey-bugs] [bug #14345] Can't compile 2.6.3 without lib-gd

[spiralvoice]

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14345>

                 Summary: Can't compile 2.6.3 without lib-gd
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: vps
            Submitted on: Di 30.08.2005 um 20:22
                Category: None
                Severity: 3 - Normal
              Item Group: Compilation problem
                  Status: Ready For Test
             Assigned to: None
             Open/Closed: Open
                 Release: 2.6.3
                 Release: 
        Platform Version: Solaris
         Binaries Origin: CVS / Self compiled
                CPU type: Sparc

    _______________________________________________________

Details:

2.6.3 won't compile if --disable-gd is specified to configure, and no gd
libraries are present in the system. The problem is that commonGlobals.ml has
references to Gd object that are always compiled.

address@hidden/sources/mldonkey-2.6.3$ LC_ALL=C make
ocamlrun ocamlc -linkall -o mlnet.byte       -custom unix.cma str.cma -ccopt
"-L/static/lib  -isystem/static/include  -I/static/include" -cclib "-lcharset
 /static/lib/libiconv.so -R/static/lib" -ccopt " " -cclib "" -cclib -lbz2
-cclib -lz -ccopt "-D_REENTRANT -pthreads"    -I build    build/cdk.cma   
build/common.cma    build/client.cma    build/core.cma    build/driver.cma   
    src/daemon/common/commonMain.cmo  
Error while linking build/common.cma(CommonGlobals):
Reference to undefined global `Gd'
make: *** [mlnet.byte] Error 2
address@hidden/sources/mldonkey-2.6.3$ 


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Mi 31.08.2005 um 00:47        By: Pawel Veselov <vps>
Applying the attached patch onto 2.6.3 release seems to work.

address@hidden/sources/mldonkey-2.6.3$ gpatch -p0 < ~/no_gd_png_ver.patch 
patching file ./src/daemon/common/commonComplexOptions.ml
Hunk #1 succeeded at 1056 (offset -1 lines).
patching file ./src/daemon/common/commonComplexOptions.mli
patching file ./src/daemon/common/commonGlobals.ml
patching file ./src/daemon/common/commonGraphics.gd.ml
patching file ./src/daemon/common/commonGraphics.nogd.ml
patching file ./src/daemon/driver/driverCommands.ml
Hunk #1 succeeded at 379 (offset -17 lines).
patching file ./src/utils/cdk/gd.ml

The code compiles now.

Thanks,
  Pawel.


-------------------------------------------------------
Date: Di 30.08.2005 um 23:06        By: spiralvoice <spiralvoice>
Thanks to pointing to CommonGlobals, please try the attached patch.







    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Di 30.08.2005 um 23:06  Name: no_gd_png_ver.patch  Size: 10,91KB   By:
spiralvoice

<http://savannah.nongnu.org/bugs/download.php?item_id=14345&item_file_id=2887>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=14345>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/