[Mldonkey-bugs] [bug #13891] Sancho is not showing when a file has been downloaded before

[anonymous]

Follow-up Comment #7, bug #13891 (project mldonkey):

Sorry, went back to mulus. Seems to be working better for me at this point of
development (not just for this issue).

About the incorrect code, I dont know who put it there or when, but I would
fix it anyway. No matter how long have you been walking on the wrong path,
come back and pick the right one.

Suppose you change the code so commited files always go to oldfiles, and
cancelled files only go to oldfiles if keep_cancelled_in_old_files is
enabled.
Think about the possible situations:

1) You have it "enabled" now. 
Current behavior: Both commited and cancelled files are added to oldfiles
New behavior: The same.

2) You have it "disabled" now.
Current behavior: No files are added to oldfiles.
New behavior: Commited files are always added to oldfiles, cancelled files
will not be added to oldfiles.

In the first case there is no difference.
In the second case, there is a difference, but its really not much problem.
Most people will never want to download the same file twice, and if they
really need to (because they deleted it by mistake or whatever), they can
always use the force_download command to do it (assuming it was not removed
from the 2.6 branch).





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=13891>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/