[Mldonkey-bugs] [bug #3296] [enhancement] why not use relative refs in HTML output?

[spiralvoice]

URL:
  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=3296>

                 Summary: [enhancement] why not use relative refs in HTML
output? 
                 Project: mldonkey, a multi-networks file-sharing client
            Submitted by: kisch
            Submitted on: Mon 21.04.2003 um 20:28
                Category: HTTP interface
                Severity: 3 - Normal
              Item Group: Feature request
                  Status: None
             Assigned to: None
             Open/Closed: Open
                 Release: None
                 Release: 2.04rc1-0
        Platform Version: Linux
         Binaries Origin: Binary from Savannah
                CPU type: None

    _______________________________________________________

Details:

Hello, thanks for your great work!

Using relative refs in the generated HTML would enhance the possibilities to
embed the mldonkey web interface into a larger apache setup.

If relative refs were used, a single apache ProxyPass directive would be
sufficient to access the mldonkey web interface. As it is, the start frame
contains requests to path-absolute URLs like e.g. /commands.html, so the
following HTTP requests all need separate rewrite rules on their own.

And because the web browser assembles complete, absolute paths for the HTTP
requests anyway from any relative path it sees in HTML, you wouldn't even have
to change the HTTP request parsing code. Just drop the leading slashes from
the output ;-)


    _______________________________________________________

Follow-up Comments:


-------------------------------------------------------
Date: Don 26.05.2005 um 15:37       By: Amorphous <amorphous>
That patch doesn't fix this.

-------------------------------------------------------
Date: Don 19.05.2005 um 01:01       By: spiralvoice <spiralvoice>
Patch #4031 should solve this.

-------------------------------------------------------
Date: Don 19.05.2005 um 00:21       By: Anonymous
fix fix fix ...

-------------------------------------------------------
Date: Don 29.04.2004 um 16:29       By: spiralvoice <spiralvoice>
Reopened because fixing this would enable the html_mods interface to be used
in a frame.

-------------------------------------------------------
Date: Mit 25.02.2004 um 01:15       By: spiralvoice <spiralvoice>
Here is some more information about Apache redirection:
http://mldonkey.berlios.de/modules.php?name=Wiki&pagename=ApacheRedirection

-------------------------------------------------------
Date: Fre 16.05.2003 um 18:06       By: Bernd Kischnick <kisch>
Thanks tharkun, for your very nice apache.conf hack!

for my apache I had to put "[P,L]" instead of "[P] [L]" at the end of the
first RewriteRule.

-------------------------------------------------------
Date: Die 22.04.2003 um 07:42       By: Anonymous
Im all for relative links but in the meantime, I use the following rewrite
rules to not have to ProxyPass all URLs myself. This will make mldonkey
available in /mldonkey on your apache.

RewriteCond      %{REQUEST_URI}           /mldonkey/.*
RewriteRule      .*/(.* ) http://www.my.dom:4080/$1 [P] [L]
# Rewrite the relative URI's mldonkey generates to use the /mldonkey/ prefix
so the
# above rewrite rule can catch it.
RewriteCond      %{HTTP_REFERER}   .*apache.my.dom/mldonkey.* 
RewriteRule      .*/(.*) http://apache.my.dom/mldonkey/$1 [R]





    _______________________________________________________

Carbon-Copy List:

CC Address                          | Comment
------------------------------------+-----------------------------
address@hidden                       | 




    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=3296>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/