[Mldonkey-bugs] [bug #12490] Fasttrack: encryption algorithm does not work correctly

[spiralvoice]

Update of bug #12490 (project mldonkey):

                Severity:              3 - Normal => 5 - Blocker            
                 Release:                2-5-30-1 => 2.5.30.6               
        Platform Version:         MinGW W2K/WinXP => None                   

    _______________________________________________________

Follow-up Comment #3:

So, I did a lot more debugging and I think the bug was that in
2-5-29 the function ml_cipher_packet_set was not properly
re-written:

http://savannah.nongnu.org/cgi-bin/viewcvs/mldonkey/mldonkey/src/networks/fasttrack/fst_crypt_ml.c.diff?r1=1.5&r2=1.6

This is the code which IMHO was not transfered properly,
patching this lets the startup tests pass without changing
encodings or other fuss:

-  ((unsigned int*)(s+pos))[0] = htonl(cipher->seed);
-  ((unsigned int*)(s+pos+4))[0] = htonl(
+  s[pos] = 250;
+  s[pos+1] = 0;
+  s[pos+2] = 182;
+  s[pos+3] = 43;
+  ((unsigned int*)(s+pos+4))[0] = htonl(cipher->seed);
+  ((unsigned int*)(s+pos+8))[0] = htonl(

I attached my patch in this bugreport.
    _______________________________________________________

Additional Item Attachment:

File name: fasttrack_check.patch          Size:0 KB
for CVS > 2-5-29
<http://savannah.nongnu.org/bugs/download.php?item_id=12490&item_file_id=2421>

    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=12490>

_______________________________________________
  Nachricht geschickt von/durch Savannah
  http://savannah.nongnu.org/