[Mldonkey-bugs] [bugs #11514] no "save" after "kill"-command

[Fritz Mock]

Follow-up Comment #8, bugs #11514 (project mldonkey):


"from driverMain.ml:

CommonGlobals.do_at_exit (fun _ ->
BasicSocket.close_all ();
Sys.remove security_space_filename;
DriverInteractive.save_config ();

CommonGlobals.print_localtime ();
lprintf (_b "Core stopped\n"));

These commands should be executed every time the core is stopped, regardless
if through process signals (SIGTERM etc.), the "kill"-command or CTRL+C
"

These commands are probably not executed everytime the core is stopped ...

Currently I am lacking time, to take a closer look at it and debug it ...
however:

The first command should -better must- fail with an exception (permission
denied), if mldonkey is stared with the -run_as_user or -run_as_uid options.
Remember, a setuid can only be done with root-privileges and the sockets are
bound prior the setuid with root-privileges. Socket-binding with root
priviledges while not running the core with root privileges is the purpose of
the above options, right?
... I bet due to an exception the game is over for the remaining commands
then ...

Not sure about a plain -daemon option, without an additional setuid, a plain
-daemon should save the ini-files.

One can check the neccessary permissions to close the sockets in different
startup-configurations with:

ls -al /proc/$(($(ps -C mlnet -o pid --no-header f|head -n1)))/fd|grep
socket



    _______________________________________________________

This item URL is:

  <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=11514>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/