[Mldonkey-bugs] [bugs #3338] Check file MD4 before commit

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #3338] Latest Modifications:

Changes by: 
                spiralvoice <address@hidden>
'Date: 
                Tue 08/10/2004 at 10:38 (Europe/Berlin)

            What     | Removed                   | Added
---------------------------------------------------------------------------
              Status | Open                      | Closed







/**************************************************************************/
[bugs #3338] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=3338>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: Markus Hitter
On: Sat 04/26/2003 at 19:47

Category:  Core
Severity:  1 - None
Item Group:  Feature request
Resolution:  Wont Fix
Assigned to:  None
Status:  Closed
Release:  2-5-12
Release:  2.04rc3
Platform Version:  Mac OS X Jaguar
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  Check file MD4 before commit

Original Submission:  Today a download ended with a bad file:

Nobile:~/MLdonkey2.04rc3/temp$ ../../md4sum-0.01.03/md4sum 
C35D85963FD1448992877AECB4BD847E 
3de5d87577920b09892c8e8109edc822
(md4 and filename differ)

The file was marked for commit. This shouldn't happen. Instead, the md4 should 
be calculated again to assure the download is fine. Just, to reassure the code 
is actually working. Remember, this bad file can be available for sharing 
without the knowledge of the user.



Follow-up Comments
------------------


-------------------------------------------------------
Date: Mon 05/03/2004 at 13:13       By: None
Use the ed2k_hash utility (compile it in mldonkey using 'make utils') instead 
of md4sum, since the ed2k hashes ARE NOT md4s, they are MD4 of the sum of the 
MD4s of all chunks (except if there is only one chunk, which explains why this 
bug appears only with big files...).

-------------------------------------------------------
Date: Mon 03/08/2004 at 16:52       By: Quorrl
I think i've the same problem, the md4 of many files i've downloaded differs 
from the entry in the files.ini.
It occured with every release up to 2.5.16, reproducable (so 
nearly every "big" download has this problem, perhaps it's cause
i've to stop and restart the mldonkey a couple of times every day)

-------------------------------------------------------
Date: Wed 02/25/2004 at 10:20       By: hitterm
This happened right last week with fresh CVS sources again.

The bug is easy to reproduce: stop mlnet, edit files.ini and set one of the 
chunks from status 0 (empty) or 1 (partial) to 2 (finished). Then wait until 
this file is finished. The file will be commited without further testing, 
spreading bad chunks into the world.

Since downloads tend to be the result of a lot of small parts and the download 
algorithm is quite complex and mlnet has to wrestle with disk full conditions 
quite often and even some users try to massage partial downloads manually, an 
additional check whould me more than welcome. Azureus offers this an an option, 
for example.



-------------------------------------------------------
Date: Wed 02/25/2004 at 01:16       By: spiralvoice
Please check if this bug still is in current CVS version.
You should a tarball of current CVS in files section of
this project: http://savannah.nongnu.org/download/mldonkey/




CC List
-------

CC Address                          | Comment
------------------------------------+-----------------------------
quorrl                              | 
t8m                                 | 









For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=3338>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/