mldonkey-bugs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Mldonkey-bugs] [bugs #9817] Friends filelist is reasked too often


From: mldonkey admin
Subject: [Mldonkey-bugs] [bugs #9817] Friends filelist is reasked too often
Date: Tue, 10 Aug 2004 04:44:48 -0400
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040113

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.

/**************************************************************************/
[bugs #9817] Latest Modifications:

Changes by: 
                mldonkey admin <address@hidden>
'Date: 
                Tue 08/10/2004 at 08:40 (GMT)

------------------ Additional Follow-up Comments ----------------------------
client_last_filereqs is not used anymore, so it won't even be saved in 
friends.ini in 2.5.27. Indeed, client_next_view_files could be saved, but from 
my point of view, it is better to always have a view of your friends files, and 
not wait for 6 hours after a restart if you had just asked before the stop. 
Anyway, I will try to reproduce the bug at home tonight.






/**************************************************************************/
[bugs #9817] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9817>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: spiralvoice
On: Fri 07/30/2004 at 02:56

Category:  eDonkey-plugin
Severity:  7 - Major
Item Group:  Program malfunction
Resolution:  None
Assigned to:  None
Status:  Open
Release:  2-5-16
Release:  
Platform Version:  None
Binaries Origin:  CVS / Self compiled
CPU type:  None


Summary:  Friends filelist is reasked too often

Original Submission:  Core does not look at our self-proposed time limit of six 
hours.
Pango wrote about it:
"the problem was that client_next_view_files was discarded when the client was 
converted to source, so the timer couldn't be remembered between connections.
So fixing it will have a memory cost (adding that timer to sources), hopefully 
acceptable."
More information about it:
http://mldonkey.berlios.de/modules.php?name=Forums&file=viewtopic&t=2689

Follow-up Comments
------------------


-------------------------------------------------------
Date: Tue 08/10/2004 at 08:40       By: mldonkey
client_last_filereqs is not used anymore, so it won't even be saved in 
friends.ini in 2.5.27. Indeed, client_next_view_files could be saved, but from 
my point of view, it is better to always have a view of your friends files, and 
not wait for 6 hours after a restart if you had just asked before the stop. 
Anyway, I will try to reproduce the bug at home tonight.

-------------------------------------------------------
Date: Mon 08/09/2004 at 15:39       By: spiralvoice
Please have a look at donkeyClient.ml, in line 650 this should happen:
    c.client_last_filereqs <- last_time ();

client_last_filereqs is saved in friends.ini, but is IMHO always zero. Correct 
me if I am wrong but I think a whole code segment is commented out in 
donkeyClient.ml, from line 676-710, so client_last_filereqs is never filled 
with a value.

The other part dealing with that is in donkeyComplexOptions.ml, and also 
commented out:

(* Is it really useful ? I don't think so. It is only used when restarting
the client several times, which is not that current...

  (try
     let last_filereqs =
       (min (get_value "client_last_filereqs" value_to_float)
          (BasicSocket.last_time ())) in
       l.client_last_filereqs <- last_filereqs
   with _ -> ()); *)


-------------------------------------------------------
Date: Mon 08/09/2004 at 14:46       By: mldonkey
I will try to reproduce this bug, but I'm not completely convinced by the 
explanation: friends are supposed to be kept in a list corresponding to the 
option, and thus, the "client" structure is never removed, even when converted 
to source and should be used when converted back from source, so that the field 
client_next_view_files should be kept from one connection to the other.













For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9817>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/







reply via email to

[Prev in Thread] Current Thread [Next in Thread]