[Mldonkey-bugs] [bugs #9697] logic bug in gnutella2 server suppression leads to dropped gnutella servers

[spiralvoice]

This mail is an automated notification from the bugs tracker
 of the project: mldonkey, a multi-networks file-sharing client.




/**************************************************************************/
[bugs #9697] Full Item Snapshot:

URL: <http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9697>
Project: mldonkey, a multi-networks file-sharing client
Submitted by: 0
On: Tue 07/20/04 at 06:38

Category:  Gnutella/G2-Plugin
Severity:  5 - Average
Item Group:  Program malfunction
Resolution:  None
Assigned to:  None
Status:  Open
Release:  2-5-21
Release:  
Platform Version:  Linux
Binaries Origin:  CVS / Self compiled
CPU type:  Intel x86


Summary:  logic bug in gnutella2 server suppression leads to dropped gnutella 
servers

Original Submission:  Line 237 of gnutellaServers.ml

if not (!gnutella2) then

should be

if !gnutella2 then


Follow-up Comments
------------------


-------------------------------------------------------
Date: Thu 07/22/04 at 04:28         By: None
With my proposal, all gnutella2 peers are dropped in gnutella2.

I don't know the answer to this. It seems that the #include
hack is not rich enough to encompass all the differences 
between gnutella and gnutella2. 

The code needs to be in gnutellaServers.ml:

if !gnutella2 then
    failwith "Gnutella2 not supported"

and in g2Servers.ml:

if not !gnutella2 then
    failwith "Gnutella servers not supported"

I suspect. The enable flag test looks like a hack to me.
But I could be wrong...

Actually, now that I'm writing this, I have a question.
Is the gnutella2 code mean to work with gnutella servers?


-------------------------------------------------------
Date: Tue 07/20/04 at 12:27         By: spiralvoice
Wouldn´t this break the use of Gnutella2 peers? The file gnutellaServers.ml 
will be copied as g2Servers.ml because of src/networks/gnutella2/g2Servers.mlt. 
Now all not-gnutella peers are dropped, with your proposal all not-G2 peers 
would be dropped.
What about this patch:

diff -x Root -x Repository -x Entries -x '*.orig' -u -N -r 
./src/networks/gnutella/gnutellaServers.ml 
./src/networks/gnutella/gnutellaServers.ml
--- ./src/networks/gnutella/gnutellaServers.ml  2004-03-07 10:34:27.000000000 
+0100
+++ ./src/networks/gnutella/gnutellaServers.ml  2004-07-20 14:21:26.000000000 
+0200
@@ -234,7 +234,7 @@
     if proto < "0.6" then
       failwith (Printf.sprintf "Bad protocol [%s]" proto)
     else
-    if not (!gnutella2) then
+    if !gnutella2 && not (!!enable_gnutella2) then
       failwith "Protocol Gnutella2 not supported"
     else
     if code <> "200" then begin







File Attachments
-------------------

-------------------------------------------------------
Date: Fri 07/23/04 at 02:28  Name: gnutella.patch  Size: 1.89KB   By: 
spiralvoice
What about this patch (untested)?
http://savannah.nongnu.org/bugs/download.php?item_id=9697&amp;item_file_id=1515






For detailed info, follow this link:
<http://savannah.nongnu.org/bugs/?func=detailitem&item_id=9697>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/