[Mldonkey-bugs] [Bug #1424] After clean: sources 0 Not enough sources 0

[nobody]

=================== BUG #1424: LATEST MODIFICATIONS ==================
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=1424&group_id=1409

Changes by: mldonkey admin <address@hidden>
Date: Mon 03/03/03 at 23:40 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
source management has changed. fixed in cvs 2.02-25




=================== BUG #1424: FULL BUG SNAPSHOT ===================


Submitted by: None                    Project: mldonkey, a free e-Donkey client
Submitted on: Tue 10/15/02 at 21:20
Category:  eDonkey-plugin             Severity:  5 - Major                  
Bug Group:  None                      Resolution:  Fixed                    
Assigned to:  None                    Status:  Closed                       
Release:  1.99 beta                   Release:  b8+7                        
Platform Version:  Linux i386-i686    Binaries Origin:  Compiled From CVS   

Summary:  After clean: sources 0 Not enough sources 0

Original Submission:  clients and sources cross reference each other: file has 
file_sources, client has client_source_for.

remove_old_clients temporarily resets file_sources list, and tries to recreate 
only entries that are not obsolete. In the end, if enough sources remain, the 
change is validated; otherwise there's a rollback.
The problem is that client_source_for reverse links are never updated ! And 
because new_source checks client_source_for, new_source always fails, and 
file_sources stay empty. The rollback is always triggered, nothing is done.

What about:
Iterate over file_sources; create the list of obsolete entries, count valid 
entries.
In the end, if enough sources remain, remove the obsolete entries, updating 
both file_sources and client_source_for.

Follow-up Comments
*******************

-------------------------------------------------------
Date: Mon 03/03/03 at 23:40         By: mldonkey
source management has changed. fixed in cvs 2.02-25


-------------------------------------------------------
Date: Fri 10/25/02 at 23:08         By: None
I think 2.00+2 closed that bug...



CC list is empty


No files currently attached


For detailed info, follow this link:
http://savannah.nongnu.org/bugs/?func=detailbug&bug_id=1424&group_id=1409