Re: [Mingw-cross-env-list] test-librsvg.exe issue

[Mark Brand]

Di Appoggio wrote:
> On my ubuntu 12.10 64 bit (under VirtualBox) I've made a clean git 
> checkout:
> when it's librsvg time have this issue:
>
>
> [cut]
> make[3]: Leaving directory `/home/marco/mxe/tmp-librsvg/librsvg-2.36.4'
> make[2]: Leaving directory `/home/marco/mxe/tmp-librsvg/librsvg-2.36.4'
> 'i686-pc-mingw32-gcc' -W -Wall -Werror -ansi -pedantic 
> './src/librsvg-test.c' -o 
> '/home/marco/mxe/usr/i686-pc-mingw32/bin/test-librsvg.exe' 
> `'i686-pc-mingw32-pkg-config' librsvg-2.0 --cflags --libs`
> /home/marco/mxe/usr/i686-pc-mingw32/lib/libharfbuzz.a(libharfbuzz_la-hb-uniscribe.o): 
> In function `hb_uniscribe_shaper_face_data_create':
> /home/marco/mxe/tmp-harfbuzz/harfbuzz-0.9.6/src/hb-uniscribe.cc:84: 
> undefined reference to address@hidden'
> /home/marco/mxe/usr/i686-pc-mingw32/lib/libharfbuzz.a(libharfbuzz_la-hb-uniscribe.o): 
> In function `hb_uniscribe_shaper_face_data_destroy':
> /home/marco/mxe/tmp-harfbuzz/harfbuzz-0.9.6/src/hb-uniscribe.cc:98: 
> undefined reference to address@hidden'
> collect2: error: ld returned 1 exit status
> make[1]: *** [build-only-librsvg] Error 1
> make[1]: Leaving directory `/home/marco/mxe'
>
> Complete log at: http://pastebin.com/nqM82hau
>
> I've fixed on my side with:
>
> diff -Nru harfbuzz-0.9.6.bak/harfbuzz.pc.in <http://harfbuzz.pc.in> 
> harfbuzz-0.9.6/harfbuzz.pc.in <http://harfbuzz.pc.in>
> --- harfbuzz-0.9.6.bak/harfbuzz.pc.in 
> <http://harfbuzz.pc.in>2012-11-17 21:28:08.308332781 +0100
> +++ harfbuzz-0.9.6/harfbuzz.pc.in <http://harfbuzz.pc.in>2012-11-17 
> 21:28:37.835964621 +0100
> @@ -7,5 +7,5 @@
>  Description: Text shaping library
>  Version: @VERSION@
> -Libs: -L${libdir} -lharfbuzz
> +Libs: -L${libdir} -lharfbuzz -lgdi32
>  Cflags: -I${includedir}/harfbuzz
>
> Is it ok?

Adding -lgdi32 like this is indeed what MXE has done in many cases. 
However, I recently stumbled on a thread in the mingw users list that 
mentioned the gcc option -mwindows

http://mingw.5.n7.nabble.com/Mingw-error-comping-openssl-td29870.html#a29873

This means less patching for MXE, which seems like a good thing. I hope 
somebody here can comment about this. Perhaps we should add "-mwindows" 
to gcc  invocations in MXE by default.

For now at least I've added -mwindows to librsvg.mk in commit fef16f87.

Mark