Re: [Mingw-cross-env-list] [PATCH] libidn: fix static linking

[Volker Grabsch]

Mark Brand schrieb:
> On 04/27/2011 03:10 PM, Martin Lambers wrote:
> >
> >the attached patch adds "-liconv" to libidn.pc. This is necessary for
> >static linking, as demonstrated by the test program that this patch also
> >adds.
> 
> Thanks. Committed:
> 
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/818032c36364

Sorry for the nitpicking, but I don't think this patch is clean.
Martin, after having invested so much time, why not investing a few
more minutes to transform your working hack into a clean patch?

First of all, since libiconv is only used internally by libidn,
the "-liconv" dependency only exists for static linking. So it
should be added to "Libs.private" instead of "Libs":

    Libs.private: -liconv

Also, "-liconv" is needed on some systems, but has to be omitted
on other systems. A quick "grep" in the config.log of Libidn reveals
that there is already an Autoconf variable for that purpose:

    LTLIBICONV='-L/.../mingw-cross-env/usr/i686-pc-mingw32/lib -liconv'

Great! So we can simply use it, making our Libs.private section
platform-independent:

    Libs.private: @LTLIBICONV@

Now, the patch is clean enough to be proposed to upstream. Unfortunately
the Libidn project has neither a mailing list nor a bug tracker. But they
accept bug fixes via email:

    http://www.gnu.org/software/libidn/#bugs

I just sent the patch to them, and also included the improved patch
into mingw-cross-env:

    http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/1e71ad3c9ac6


Greets,
Volker

-- 
Volker Grabsch
---<<(())>>---