Re: stray dot in freetds configure on OSX (was Re: Freetds (was Re: [Mingw-cross-env-list] changes pushed))

[Tony Theodore]

On 12 September 2010 07:33, Tony Theodore <address@hidden> wrote:
> On 12 September 2010 06:53, Mark Brand <address@hidden> wrote:
>>
>> A wild guess would be that your "echo" does not like the "-n" at line 5 in
>> configure.ac:
>>
>>> AC_INIT(FreeTDS, 0.83.dev.esyscmd(echo -n $(date +"%Y%m%d")))
>>
>> Care to experiment?
>
> Indeed, I've wasted time playing with various versions of autotools
> and bash. From man echo:
>
>  Most notably, the builtin echo in sh(1) does not accept the -n option.
>
>  Applications aiming for maximum portability are strongly encouraged to use
>           printf(1) to suppress the newline character.
>
>
> This works on OSX:
>
> diff -r ffaeb3439286 src/freetds.mk
> --- a/src/freetds.mk    Sat Sep 11 21:03:14 2010 +0200
> +++ b/src/freetds.mk    Sun Sep 12 07:27:39 2010 +1000
> @@ -21,6 +21,7 @@
>  endef
>
>  define $(PKG)_BUILD
> +    $(SED) -i 's,echo -n,printf,' '$(1)/configure.ac'
>     cd '$(1)' && NOCONFIGURE=true ./autogen.sh
>     cd '$(1)' && $(LIBTOOLIZE)
>
>
> But I haven't tested it on other systems. Some other options may be
> setting SHELL or CONFIG_SHELL, I'll look at it tomorrow.

I've tried various other things, but the printf replacement seems to
be the only one that works. It works on FreeBSD and Ubuntu also, so it
should be safe to change.

Cheers,

Tony