Re: Remove thingiview.

[jgart]

Hi Ben,

> Thanks for the patch! I'm sorry that I've given you the wrong impression
> here - the aim is not literally to delete thingiview and leaflet, but
> rather just not to include them in the Guix packaging. 

What are your thoughts for not including that javascript in the guix package?

Here's are small list to clarify/elaborate my thinking on it:

1. I'm not sure if guix upstream would accept a service that has unused 
javascript files being referenced in its master branch. It might be good to ask 
about that just to make sure. 

2. Guix upstream is hoping we present them with less javascript files that get 
installed to /gnu/store

3. If the javascript files are unused why would we want to keep them in the 
master branch that is presented to guix upstream instead of just archiving them 
in a branch or tag for perusal? It would be easier to remove them from master 
and put them in another branch or tag. Otherwise, we'll have to delete those 
unused bundled javascript files programatically with guile in the guix package 
that runs in production. This will increase the amount of code that we have to 
write in the guix package. 

4. We could always view the archived javascript files by visiting a previous 
commit or perusing them in a separate branch or tag.

What are your thoughts about the above?

> The challenge will be figuring out how best to add jquery,
> video.js and videojs-resolution-switcher to the Guix package when they
> normally come from NPM.

We would add the unminified but concatenated jquery and videojs sources as 
assets in the same way that cuirass does.

If we could not depend on videojs in the future that would be great for 
reducing the size. Videojs has alot of direct dependencies to manage compared 
to jquery. See the issue opened here: 
https://github.com/videojs/video.js/issues/5632.

all the best,

jgart

April 20, 2021 8:07 AM, "Ben Sturmfels" <ben@sturm.com.au> wrote:

> Hi jgart,
> 
> On Tue, 20 Apr 2021, jgart wrote:
> 
>> Here's a patch to remove the thingiview stuff.
> 
> Thanks for the patch! I'm sorry that I've given you the wrong impression
> here - the aim is not literally to delete thingiview and leaflet, but
> rather just not to include them in the Guix packaging. That's done by
> default because we can't install from NPM during `guix build`.
> 
> The challenge will be figuring out how best to add jquery,
> video.js and videojs-resolution-switcher to the Guix package when they
> normally come from NPM.
> 
> Thanks again for your work though.
> 
> Regards,
> Ben