Having a separate file with some local settings overwriting
global ones would've been useful in some setups, but mediagoblin_local.ini
is not handled as such -- in its presence the "global"
mediagoblin.ini is not read at all:
if
os.path.exists(os.path.abspath('mediagoblin_local.ini')):
default_conf_file =
'mediagoblin_local.ini'
else:
default_conf_file = 'mediagoblin.ini'
I do not see, how this is useful to anyone. mediagoblin.example.ini
already provides the list of configurable knobs... I'd propose, for
mediagoblin_local.ini be obsoleted and the next release to
start warning people, if the file is detected (but is not found in $MEDIAGOBLIN_CONFIG),
that it is no longer considered.
Either that, or modify the configuration-parsing routines to always
parse the mediagoblin.ini first and then allow mediagoblin_local.ini
(if found) to overwrite some of the settings without having
to overwrite all of them.
Yours,
-mi
|