maposmatic-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Maposmatic-dev] [PATCH 2/8] Simplify preparePaperPanel() function


From: Thomas Petazzoni
Subject: [Maposmatic-dev] [PATCH 2/8] Simplify preparePaperPanel() function
Date: Sat, 7 Aug 2010 11:18:47 +0200

We factorize a little bit the code to make the function simpler and
easier to read.

Signed-off-by: Thomas Petazzoni <address@hidden>
---
 www/media/map_rendering_form.js |   35 ++++++++++++++++-------------------
 1 files changed, 16 insertions(+), 19 deletions(-)

diff --git a/www/media/map_rendering_form.js b/www/media/map_rendering_form.js
index 5a4548d..a146fdf 100644
--- a/www/media/map_rendering_form.js
+++ b/www/media/map_rendering_form.js
@@ -127,32 +127,29 @@ function filterAllowedPaper(paperlist)
 
 function preparePaperPanel()
 {
+    /* Start the Ajax request to get the list of allowed paper
+     * sizes */
     $("#paperselection").hide();
     if (getCurrentMode() == 'bbox')
     {
-      $.post("/apis/papersize/", {
-                lat_upper_left   : $("#lat_upper_left").val(),
-                lon_upper_left   : $("#lon_upper_left").val(),
-                lat_bottom_right : $("#lat_bottom_right").val(),
-                lon_bottom_right : $("#lon_bottom_right").val(),
-                layout           : $("input[name='layout']:checked").val()
-             },
-             function(data) {
-                filterAllowedPaper(data);
-             }
-            );
+        args = {
+            lat_upper_left   : $("#lat_upper_left").val(),
+            lon_upper_left   : $("#lon_upper_left").val(),
+            lat_bottom_right : $("#lat_bottom_right").val(),
+            lon_bottom_right : $("#lon_bottom_right").val(),
+            layout           : $("input[name='layout']:checked").val()
+        };
     }
     else
     {
-      $.post("/apis/papersize/", {
-                osmid: $("#id_administrative_osmid").val(),
-                layout           : $("input[name='layout']:checked").val()
-             },
-             function(data) {
-                filterAllowedPaper(data);
-             }
-            );
+        args = {
+            osmid  : $("#id_administrative_osmid").val(),
+            layout : $("input[name='layout']:checked").val()
+        };
     }
+
+    $.post("/apis/papersize/", args,
+           function(data) { filterAllowedPaper(data); });
 }
 
 /** When using a by admin boundary area, contains the country code of
-- 
1.7.0.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]