[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH maposmatic 2/2] Implement the "Recreate Map

From: David MENTRE
Subject: Re: [Maposmatic-dev] [PATCH maposmatic 2/2] Implement the "Recreate Map" feature
Date: Tue, 1 Jun 2010 17:32:08 +0200

Hi Maxime,

2010/6/1 Maxime Petazzoni <address@hidden>:
> Note that I didn't add/change this. It's barely a duplicate of the
> already existing rendering_already_exists code that looked for
> successful renderings by administrative boundary and which already used
> status==2 in its query.

OK. So all that status==2 code is bad. :)

> The rendering_already_exists_by_{bbox,osmid}() code has no effect on the
> appearance of the button. The buttons appears when the job is not in the
> "needs waiting" status, i.e. when the job has been processed, had it
> failed or succeeded (see templates/maposmatic/job.html in the patch).

Ok, sorry, I misread your patch.

> Other than that, is the patch ok for merging?

I think so, but my opinion is rather lightweight considering my current
involvement in maposmatic.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]