[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Maposmatic-dev] [PATCH maposmatic 1/3] Cornerstones for a new MapOS
From: |
Thomas Petazzoni |
Subject: |
Re: [Maposmatic-dev] [PATCH maposmatic 1/3] Cornerstones for a new MapOSMatic daemon |
Date: |
Wed, 10 Feb 2010 20:49:58 +0100 |
On Wed, 10 Feb 2010 20:19:30 +0100
David MENTRE <address@hidden> wrote:
> I have finally (quickly) looked at your code. No special opinion about
> it. I'm not a huge fan of threading and all those parallel things (to
> say the least). For me it can quickly become a big source of issues
> and their advantages (if any) should be carefully balanced with added
> complexity. I would have preferred the cleanup being done serially as
> before and not in a separate thread. But as you have written it that
> way...
I share the same opinion. And to me, parallel processing is not a
priority, since the long rendering times can be fixed by improving the
SQL requests we are doing.
> In short: go ahead, you'll debug it if it breaks. ;-)
Agreed. Now that the work is done, please merge the patches.
Cheers,
Thomas
--
Thomas Petazzoni http://thomas.enix.org
Promouvoir et défendre le Logiciel Libre http://www.april.org
Logiciels Libres à Toulouse http://www.toulibre.org
signature.asc
Description: PGP signature