[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH maposmatic] Add a rendered maps feed

From: Thomas Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH maposmatic] Add a rendered maps feed
Date: Tue, 9 Feb 2010 22:36:31 +0100


Great that you picked this task!

On Thu,  4 Feb 2010 22:38:50 +0100
Maxime Petazzoni <address@hidden> wrote:

> This change introduces a RSS feeds for the successfully rendered maps
> that still have their files available (status=2), using the Django
> syndication framework.
> It uses a custom map-feed.html template instead of the map.html in
> order to include styling information directly in the HTML an
> accomodate for the variable naming from the syndication framework.
> This new MapOSMatic maps feed is now available from a traditional RSS
> icon link on the maps page.

Ok for me, except one question :

> +        return (models.MapRenderingJob.objects
> +                .filter(status=2)
> +                .filter(resultmsg='ok')
> +                .order_by('-endofrendering_time')[:10])

If I understand correctly, it means that at any given time, the RSS
feed will only contains the 10 latest renderings. It means that if the
mean rendering for the last 10 renderings is 4 minutes, they will
disappear after 40 minutes.

If the user reloads its RSS feed only every hour, or worse everyday,
the user will miss a lot of renderings.

So I think we should list a larger number of renderings, or list all
renderings for the past 24/48 hours ?


Thomas Petazzoni               
Promouvoir et défendre le Logiciel Libre
Logiciels Libres à Toulouse    

Attachment: signature.asc
Description: PGP signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]