[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH maposmatic] Provide a map_areas_prefix to th

From: Maxime Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH maposmatic] Provide a map_areas_prefix to the OCitySMap constructors
Date: Mon, 25 Jan 2010 11:29:12 +0100
User-agent: Mutt/1.5.20 (2009-06-14)

* David MENTRE <address@hidden> [2010-01-25 11:24:41]:

> 2010/1/23 Maxime Petazzoni <address@hidden>:
> > +    prefix = 'maposmaticd_%d_' % os.getpid()
> A little comment : above code is used twice, in both ocitysmap and
> maposmatic. Shouldn't we factorize it into a module of ocitysmap?

I don't think so. It's the responsibily of the caller here to provide
a sensible table prefix. So both ocitysmap-render and maposmaticd
provide the prefix they think is best.

We could make OCitySMap create a temporary prefix on its own, ensuring
uniqueness, but it's probably not worth the complexity.

We can still change this later if we find something more clever.

- Maxime
Maxime Petazzoni <>
 ``One by one, the penguins took away my sanity.''
Linux kernel and software developer at MontaVista Software

Attachment: signature.asc
Description: Digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]