[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH maposmatic] Improve the file cleanup mechan

From: David MENTRE
Subject: Re: [Maposmatic-dev] [PATCH maposmatic] Improve the file cleanup mechanism
Date: Wed, 13 Jan 2010 16:24:49 +0100

Hi Maxime,

2010/1/13 Maxime Petazzoni <address@hidden>:
>     def is_done(self):
> -        return self.status == 2
> +        return self.status >= 2

You are changing the semantics of is_done (which was previously "done
with files"). Anyway, even if you decide to change the semantics of
is_done, I would rather write:
  self.status == 2 || self.status == 3
In the sake of prevention against further changes.

>     def is_done_ok(self):
>         return self.is_done() and self.resultmsg == "ok"

In that case, we could have a job is_done==True, resultmsg=="ok" but
no file (if status == 3).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]