maposmatic-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Maposmatic-dev] [PATCH] Add the right-to-left stylesheet


From: Thomas Petazzoni
Subject: Re: [Maposmatic-dev] [PATCH] Add the right-to-left stylesheet
Date: Mon, 11 Jan 2010 21:56:04 +0100

Le Mon, 11 Jan 2010 12:46:27 +0100,
Maxime Petazzoni <address@hidden> a écrit :

>   * find a way to include this stylesheet in addition to the normal
> one when displaying a RTL language;

Done:
http://git.savannah.gnu.org/cgit/maposmatic.git/commit/?id=7e2391299eb00ba35c8f148d74c0f28eae0f6183

I've already slightly improved the language selector so that regardless
of the currently selected language, all languages are displayed in
*their* direction. I'm special casing the Arabic language since I don't
know how to properly get the value of LANGUAGES_BIDI (from
django.conf.global_settings) :
http://git.savannah.gnu.org/cgit/maposmatic.git/commit/?id=38b825651f4f7c9d3fb05efc91abeaa6f9987fd0

>   * a few places here and there needs i18n fixes, using more
> blocktrans blocks to include the variables as python-format in the
> translatable strings to ensure proper ordering when displaying RTL.

Could you report them ?

>   * a RTL header background with some Arabic location map background?

To begin with, just a RTL header will be enough. Since you generated
the LTR one, could you generate this one too ?

Thanks!

Thomas
-- 
Thomas Petazzoni                         http://thomas.enix.org
Promouvoir et défendre le Logiciel Libre http://www.april.org
Logiciels Libres à Toulouse              http://www.toulibre.org

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]