Re: [Man-db-devel] man-db autotools clean up & gnulib update

[Sami Kerola]

On Tue, Apr 10, 2012 at 01:55, Colin Watson <address@hidden> wrote:
> On Mon, Apr 09, 2012 at 11:19:38PM +0200, Sami Kerola wrote:

>> I pulled man-db from bazaar, and found out it did not quite work
>> for me. Problem was gnulib/po directory that caused make to exit,
>> and I traced the problem that I did not have gnulib-tools in path.
>> To fix that I end up to do slightly greater patch than I
>> anticipated originally. Basically it will clean up all
>> autogenerated files, and will set the expectation for people who
>> use Bazaar to use ./autogen.sh before ./configure && make.
>
> Thanks for your suggestion, but no, sorry, I'm not going to remove
> those autogenerated files from Bazaar. I'm well aware that many
> maintainers of other projects disagree with me, but I like it this
> way and made up my mind a long time ago: the chief advantage is
> that it makes it easy for me to see what autotools updates are
> doing.

OK. I will add that to docs/HACKING some day, unless you are
quicker.

> I understand that you found a real problem, but find some other
> solution to it. :-) For example, it probably wouldn't be too
> unreasonable for autogen.sh to duplicate the bit of gnulib-tool
> that fetches PO files.

The gnulib/po/ requires more than just *.po files, to be precise the
files are generated by autopoint. If all other auto files are in repo
I feel these should be as well.

added:
  gnulib/po/
  gnulib/po/LINGUAS
  gnulib/po/Makefile.in.in
  gnulib/po/Makevars
  gnulib/po/Makevars.template
  gnulib/po/POTFILES.in
  gnulib/po/Rules-quot
  gnulib/po/af.po
  gnulib/po/be.po
  gnulib/po/bg.po
  gnulib/po/boldquot.sed
  gnulib/po/ca.po
  gnulib/po/cs.po
  gnulib/po/da.po
  gnulib/po/de.po
  gnulib/po/el.po
  gnulib/po/address@hidden
  gnulib/po/address@hidden
  gnulib/po/es.po
  gnulib/po/et.po
  gnulib/po/eu.po
  gnulib/po/fi.po
  gnulib/po/fr.po
  gnulib/po/ga.po
  gnulib/po/gl.po
  gnulib/po/hu.po
  gnulib/po/insert-header.sin
  gnulib/po/it.po
  gnulib/po/ja.po
  gnulib/po/ko.po
  gnulib/po/ms.po
  gnulib/po/nb.po
  gnulib/po/nl.po
  gnulib/po/pl.po
  gnulib/po/pt.po
  gnulib/po/pt_BR.po
  gnulib/po/quot.sed
  gnulib/po/remove-potcdate.sin
  gnulib/po/ro.po
  gnulib/po/ru.po
  gnulib/po/rw.po
  gnulib/po/sk.po
  gnulib/po/sl.po
  gnulib/po/sv.po
  gnulib/po/tr.po
  gnulib/po/uk.po
  gnulib/po/vi.po
  gnulib/po/zh_CN.po
  gnulib/po/zh_TW.po


Adding the gnulib/po/ files is not going work well, unless  bzr
clean-tree --ignored instructed not to clean up these files.

$ bzr diff .bzrignore autogen.sh
=== modified file '.bzrignore'
--- .bzrignore  2012-02-01 23:46:33 +0000
+++ .bzrignore  2012-04-10 07:52:22 +0000
@@ -45,7 +45,6 @@
 gnulib/lib/warn-on-use.h
 gnulib/lib/wchar.h
 gnulib/lib/wctype.h
-gnulib/po
 include/*.h
 lib/.deps
 lib/Makefile

Unfortunately for now I do not have time to run test with this patch
in which would try perform bazaar build with & without gnulib-tools
in path.

See attached gnulib-po.diff.gz for how I made this change.

> Also, I'm not going to update gnulib directly from upstream git; I
> much prefer to update it from the package in Debian unstable
> because that provides some reassurance that gnulib isn't broken at
> the time I do the update.

This ought to be in docs/HACKING as well.

>> p.s. Should I join the mail list and submit the patch there? This
>> is after all unusually large change.
>
> You're welcome to send patches to the list, certainly.

CC:ing the list. And now one I'll send everything to the list as
well.

-- 
   Sami Kerola
   http://www.iki.fi/kerolasa/

gnulib-po.diff.gz
Description: GNU Zip compressed data