[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Minor patch to correct buffer overrun
From: |
Eli Zaretskii |
Subject: |
Re: Minor patch to correct buffer overrun |
Date: |
Fri, 27 Aug 2010 09:41:13 +0300 |
> Date: Thu, 26 Aug 2010 21:53:11 -0400
> From: Chris Sutcliffe <address@hidden>
> CC: address@hidden, address@hidden
>
> On 26/08/2010 1:15 PM, Eli Zaretskii wrote:
> >> Is the comment appropriate?
> > Yes, but please format it according to the GNU coding standards:
> >
> > /* bla bla bla
> > yak yak yak. */
>
> Done:
>
> --- make.h.orig 2010-07-20 09:12:06 -0400
> +++ make.h 2010-08-26 21:49:15 -0400
> @@ -306,10 +306,14 @@
> #define S_(msg1,msg2,num) ngettext (msg1,msg2,num)
>
> /* Handle other OSs. */
> -#ifndef PATH_SEPARATOR_CHAR
> -# if defined(HAVE_DOS_PATHS)
> -# define PATH_SEPARATOR_CHAR ';'
> -# elif defined(VMS)
> +/* To overcome an issue parsing paths in a DOS/Windows environment when
> + built in a unix based environment, override the PATH_SEPARATOR_CHAR
> + definition unless being built for Cygwin. */
> +#if defined(HAVE_DOS_PATHS) && !defined(__CYGWIN__)
> +# undef PATH_SEPARATOR_CHAR
> +# define PATH_SEPARATOR_CHAR ';'
> +#elif !defined(PATH_SEPARATOR_CHAR)
> +# if defined (VMS)
> # define PATH_SEPARATOR_CHAR ','
> # else
> # define PATH_SEPARATOR_CHAR ':'
Fine with me. If Paul doesn't object, I will commit this upstream.
Thanks.
- Re: Minor patch to correct buffer overrun, (continued)
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/19
- Re: Minor patch to correct buffer overrun, Paul Smith, 2010/08/19
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/19
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/19
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/20
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/26
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/26
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/26
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/26
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/26
- Re: Minor patch to correct buffer overrun,
Eli Zaretskii <=
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/27
- Re: Minor patch to correct buffer overrun, Paul Smith, 2010/08/28
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/28
- Re: Minor patch to correct buffer overrun, Chris Sutcliffe, 2010/08/30
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/18
- Re: Minor patch to correct buffer overrun, Paul Smith, 2010/08/16
- Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/16
Re: Minor patch to correct buffer overrun, Eli Zaretskii, 2010/08/16