RE: Bug report: Compile with Microsoft and Intel compiler

[Jerker Bäck]

Preprocessed code of GNU make by the Microsoft compiler 13.10
Extractions of the generated "i" files for parts of the code which generate
warnings

---------------------------------------------
file.c(553) : error C4296: '<' : expression is always false
file.c(553) : error C4307: '+' : integral constant overflow
file.c(554) : error C4296: '<' : expression is always false
file.c(554) : error C4307: '+' : integral constant overflow

if (! (s <= FILE_TIMESTAMP_S (ORDINARY_MTIME_MAX)
 && product <= ts && ts <= ORDINARY_MTIME_MAX))
{

expands to:

if (! (s <= (((((((((~ (unsigned long) 0 - (! ((unsigned long) -1 < 0) ? 
        (unsigned long) 0 : ~ (unsigned long) 0 << 
        (sizeof (unsigned long) * 8 - 1)))) - (2 + 1)) >> 
        (0 ? 30 : 0)) << (0 ? 30 : 0)) + (2 + 1) + (0 ? 1000000000 : 1) -
1))
        - (2 + 1)) >> (0 ? 30 : 0)) 
        && product <= ts && ts <= 
        ((((((~ (unsigned long) 0 - (! ((unsigned long) -1 < 0) ? 
        (unsigned long) 0 : ~ (unsigned long) 0 << (sizeof (unsigned long) *
8 - 1)))) - 
        (2 + 1)) >> (0 ? 30 : 0)) << (0 ? 30 : 0)) + (2 + 1) + (0 ?
1000000000 : 1) - 1)))
{

---------------------------------------------
file.c(557) : error C4296: '<' : expression is always false
file.c(557) : error C4307: '+' : integral constant overflow

ts = s <= OLD_MTIME ? ORDINARY_MTIME_MIN : ORDINARY_MTIME_MAX;

expands to:

ts = s <= 2 ? (2 + 1) : 
        ((((((~ (unsigned long) 0 - (! ((unsigned long) -1 < 0) ? 
                (unsigned long) 0 : ~ (unsigned long) 0 << (sizeof (unsigned
long) * 8 - 1)))) - 
                (2 + 1)) >> (0 ? 30 : 0)) << (0 ? 30 : 0)) + (2 + 1) + (0 ?
1000000000 : 1) - 1);

---------------------------------------------
function.c(512) : error C4130: '==' : logical operation on address of string
constant

int is_suffix = streq (funcname, "suffix");

expands to:

int is_suffix = ((funcname) == ("suffix") || 
        (*(funcname) == *("suffix") && (*(funcname) == '\0' || 
        !strcmp ((funcname) + 1, ("suffix") + 1))));

---------------------------------------------
function.c(536) : error C4130: '==' : logical operation on address of string
constant

else if (streq (funcname, "notdir") && p2[0] && p2[1] == ':')
{

expands to:

else if (((funcname) == ("notdir") || (*(funcname) == *("notdir") &&
                 (*(funcname) == '\0' || !strcmp ((funcname) + 1, ("notdir")
+ 1)))) && 
                 p2[0] && p2[1] == ':')
{

---------------------------------------------
function.c(570) : error C4130: '==' : logical operation on address of string
constant

int is_basename= streq (funcname, "basename");

expands to:

int is_basename= ((funcname) == ("basename") || 
        (*(funcname) == *("basename") && (*(funcname) == '\0' || 
        !strcmp ((funcname) + 1, ("basename") + 1))));

---------------------------------------------
function.c(622) : error C4130: '==' : logical operation on address of string
constant

int is_addprefix = streq (funcname, "addprefix");

expands to:

int is_addprefix = ((funcname) == ("addprefix") || 
        (*(funcname) == *("addprefix") && (*(funcname) == '\0' || 
        !strcmp ((funcname) + 1, ("addprefix") + 1))));

---------------------------------------------
function.c(910) : error C4130: '==' : logical operation on address of string
constant

int is_filter = streq (funcname, "filter");

expands to:

int is_filter = ((funcname) == ("filter") || 
        (*(funcname) == *("filter") && (*(funcname) == '\0' || 
        !strcmp ((funcname) + 1, ("filter") + 1))));

---------------------------------------------
hash.c(49) : error C4115: 'token' : named type definition in parentheses
hash.c(265) : error C4115: 'token' : named type definition in parentheses

ht->ht_vec = (void**) CALLOC (struct token *, ht->ht_size);

expands to:

ht->ht_vec = (void**) ((struct token * *) 
        calloc (sizeof (struct token *), (ht->ht_size)));

struct token is undefined

---------------------------------------------
main.c(1728) : error C4296: '<' : expression is always false

f->last_mtime = f->mtime_before_update = NEW_MTIME;

expands to:

f->last_mtime = f->mtime_before_update = 
(~ (unsigned long) 0 - (! ((unsigned long) -1 < 0) ? 
 (unsigned long) 0 : ~ (unsigned long) 0 << 
 (sizeof (unsigned long) * 8 - 1)));

---------------------------------------------
read.c(1790) : error C4130: '==' : logical operation on address of string
constant

if (streq (name, ".POSIX"))

expands to:

if (((name) == (".POSIX") || (*(name) == *(".POSIX") && 
        (*(name) == '\0' || !strcmp ((name) + 1, (".POSIX") + 1)))))

---------------------------------------------
remake.c(431) : error C4296: '<' : expression is always false
remake.c(431) : error C4307: '+' : integral constant overflow

else if (ORDINARY_MTIME_MIN <= this_mtime && this_mtime <=
ORDINARY_MTIME_MAX

expands to:

else if ((2 + 1) <= this_mtime && this_mtime <= 
        ((((((~ (unsigned long) 0 - (! ((unsigned long) -1 < 0) ? 
        (unsigned long) 0 : ~ (unsigned long) 0 << (sizeof (unsigned long) *
8 - 1)))) - 
        (2 + 1)) >> (0 ? 30 : 0)) << (0 ? 30 : 0)) + (2 + 1) + (0 ?
1000000000 : 1) - 1)

---------------------------------------------
remake.c(862) : error C4296: '<' : expression is always false

file->last_mtime = i == 0 ? UNKNOWN_MTIME : NEW_MTIME;

expands to:

file->last_mtime = i == 0 ? 0 : 
        (~ (unsigned long) 0 - (! ((unsigned long) -1 < 0) ? 
                (unsigned long) 0 : ~ (unsigned long) 0 << 
                (sizeof (unsigned long) * 8 - 1)));

---------------------------------------------
variable.c(285) : error C4130: '==' : logical operation on address of string
constant

if (streq (var->name, ".VARIABLES")
  && global_variable_set.table.ht_fill != last_var_count)
{

expands to:

if (((var->name) == (".VARIABLES") || (*(var->name) == *(".VARIABLES")
        && (*(var->name) == '\0' || !strcmp ((var->name) + 1, (".VARIABLES")
+ 1))))
        && global_variable_set.table.ht_fill != last_var_count)
{

---------------------------------------------
variable.c(868) : error C4130: '==' : logical operation on address of string
constant

if (streq (v->name, "SHELL"))
{

expands to:

if (((v->name) == ("SHELL") || (*(v->name) == *("SHELL") 
        && (*(v->name) == '\0' || !strcmp ((v->name) + 1, ("SHELL") + 1)))))
{

---------------------------------------------
variable.c(1118) : error C4130: '==' : logical operation on address of
string constant

#ifdef WINDOWS32
if ((origin == o_file || origin == o_override) && streq (varname, "SHELL"))
{

expands to:

if ((origin == o_file || origin == o_override) && ((varname) == ("SHELL") 
        || (*(varname) == *("SHELL") && (*(varname) == '\0' 
        || !strcmp ((varname) + 1, ("SHELL") + 1)))))
{

---------------------------------------------

Regards Jerker