[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] OS/2 patches for master branch, try 2

From: KO Myung-Hun
Subject: Re: [PATCH] OS/2 patches for master branch, try 2
Date: Sat, 22 Nov 2014 15:44:15 +0900
User-agent: Mozilla/5.0 (OS/2; Warp 4.5; rv:10.0.6esrpre) Gecko/20120715 Firefox/10.0.6esrpre SeaMonkey/2.7.2


Gary V. Vaughan wrote:
> On Nov 20, 2014, at 10:33 PM, Gary V. Vaughan <address@hidden> wrote:
>> On Nov 20, 2014, at 4:55 AM, KO Myung-Hun <address@hidden> wrote:
>>> These are OS/2 patches for master branch. Patches for 1.4 branch are
>>> reflected.
>>> [PATCH 1/5] configury: support DLLs on OS/2
>> Agreed.  But these flags apply to more than just OS/2, so I turned on 
>> -avoid-version and -no-undefined unconditionally.
>>> [PATCH 2/5] m4: support to load modules on OS/2
>> In principle, these seem like good changes, but the implementation is not as 
>> clean as it could be, considering many of these changes certainly may apply 
>> on more than just OS/2.  I've rewritten equivalents to everything except 
>> module name truncation to 8 characters maximum, which I'll figure out how to 
>> do nicely tomorrow.
> On reflection, falling back to the system dlopen() search path is both a 
> security risk, and breaks the process for loading frozen files in the current 
> format, so I reverted that part.  If you need that functionality, then set 
> M4PATH appropriately in the environment, or from a wrapper script e.g.:


And NEED_USCORE is not defined on OS/2 in spite of its being required.
I've fixed libtool and sent the patch. Would you mind reviewing it ?

> I found a nice way to consistently perform path truncation during path 
> searching, though I only tested it lightly from gdb, so please confirm if it 
> works for you as expected on OS2.

I found some problems.

1. A null-terminator may not be appended.
2. A length is invalidated when a path is truncated really.

I attach the fix.

>>> [PATCH 3/5] configury: append $EXEEXT suffix to the executable,
>>> [PATCH 4/5] configury: add -Zargs-resp to LDFLAGS on OS/2.
>>> [PATCH 5/5] esyscmd: fdopen() with a text mode explicitly on OS/2.
>> Ack.
>> Effectively applied and pushed everything here, or equivalents - save module 
>> name truncation.

Thanks a lot.

KO Myung-Hun

Using Mozilla SeaMonkey 2.7.2
Under OS/2 Warp 4 for Korean with FixPak #15
In VirtualBox v4.1.32 on Intel Core i7-3615QM 2.30GHz with 8GB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr

Attachment: 0001-libm4-fix-regression-of-2c19e82d5d813565abfc2aca0085.patch
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]