[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] fix bootstrapping and module loading (was: [PATCH] build: fi

From: Gary V. Vaughan
Subject: Re: [PATCH] fix bootstrapping and module loading (was: [PATCH] build: fix bootstrapping)
Date: Fri, 21 Nov 2014 19:31:51 +0000

Hi Pavel,

> On Nov 21, 2014, at 8:49 AM, Pavel Raiskup <address@hidden> wrote:
> On Friday 15 of August 2014 10:45:02 Pavel Raiskup wrote:
>> On Saturday 14 of June 2014 19:15:51 Pavel Raiskup wrote:
>>> On Thursday 29 of May 2014 17:29:30 Pavel Raiskup wrote:
>>>> On Tuesday 27 of May 2014 08:58:22 Pavel Raiskup wrote:
>>>>> On Monday 26 of May 2014 21:14:23 Eric Blake wrote:
>>>>>> That said, I'll probably apply this once I know more about why it is
>>>>>> needed.
>>>>> Please don't, the patch is not correct.  I'll repost better one.  When
>>>>> man pages are generated by help2man, the man page target should not be
>>>>> dependant on generated binary (when help2man is also not distributed,
>>>>> which is IMO bad idea in principle).
>>>> Sorry for the delay.  I tried to fix yet another problem blocking me from
>>>> building that in Copr [1].
>>>> Patch 0000:
>>>> [..snip..]
>>>> Patch 0001 enables module loading and file inclusions on my machine (and
>>>> [..snip..]
>>> Ping?
>> Gently pinging again :).
> Ping again? :)  Patches rebased against current master and attached.

Starting slowly, your first patch conflates two separate changes.  The first of
those bringing back the correct use of LT_LIB_DLLOAD so that LIBADD_DL is set
correctly for Makefile.in.

That seems slightly wrong to me, because master has not used libltdl for a 
I've added the macro, but instead of removing LIBADD_DL from the link libraries,
I removed LIBLTDL.

Does this work for you too?  (There's no need for -ldl on Mac OS, so I can't
test easily).

Gary V. Vaughan (gary AT gnu DOT org)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]