[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: distributing and cleaning

From: Eric Blake
Subject: Re: distributing and cleaning
Date: Mon, 19 Jun 2006 19:09:45 +0000 (UTC)
User-agent: Loom/3.14 (http://gmane.org/)

Hi Ralf,

Ralf Wildenhues <Ralf.Wildenhues <at> gmx.de> writes:

> Ignoring the test failures for a moment, I need something like this to
> get distcheck to pass.

OK, I just found 'make distcheck TESTSUITEFLAGS=--version' as a nice way to 
bypass running any tests, thus ignoring other failures in the testsuite while 
still testing the distribution.

> - stamp-vcl was leftover by distclean; I'm not sure if you want it
>   distributed, but that is what CVS Libtool does; OTOH, it also always
>   updates it in the source tree.

I already updated this to do what libtool does.

> - a bogus entry 'm4' in DISTCLEANFILES.

Not bogus; I previously fixed it to list the directory name that was 
inadvertantly left off when converting to non-recursive Makefiles; as we really 
do want to clean up the wrapper tests/m4.

> - modules/perl.c is listed in POTFILES.  Either distribute it as well,
>   or manually delist it.

Thanks; I think distribution is correct, in case someone wants to play with it.

> - There is a buglet in CVS Automake: it does not realize that src may
>   have a subdirectory for libtool objects.  I'll report this upstream,
>   the patch below has a workaround.

Have you reported this upstream yet?  Hopefully the fix will make it in 
automake 1.10.

> - Since src/m4 explicitly links against m4/libm4.la, I'd add it to
>   src_m4_DEPENDENCIES as well, even if the dependency is already
>   implicit by the PREOPEN_DEPENDENCIES.  This is cleaner IMHO.

Done.  Thanks for the patch; I committed:

        * Makefile.am (src_m4_DEPENDENCIES): Make dependency explicit.
        (clean-local): Split into and depend upon...
        (clean-local-tests, clean-local-src): ...these two.  The latter
        removes the libtool object directory below `src', to work around
        a buglet in Automake, failing to list it.
        (EXTRA_DIST): Distribute modules/perl.c.

Eric Blake

reply via email to

[Prev in Thread] Current Thread [Next in Thread]