[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: push_string_init calling check

From: Eric Blake
Subject: Re: push_string_init calling check
Date: Thu, 11 May 2006 07:26:47 -0600
User-agent: Thunderbird (Windows/20060308)

Hash: SHA1

According to Ilya N. Golubev on 1/10/2006 1:21 PM:
> CVS branch: branch-1_4
> <recursive push_string with non-gnu cc> posted on Thu, 10 Nov 2005
> 18:08:17 +0300 (<address@hidden>) describes an internal
> error that occurs in certain build configurations unconditionally once
> certain line of C code is executed, one with `push_string_init ()'
> passed to macro.  Batch oriented tests done by `make check' should
> readily detect that, but they do not, all of them are passed.  `gcov'
> shows that, when m4 built with gcc, that line is never executed by
> tests either.  Fixing that as follows.  (Certainly test file name is
> unimportant and may be easily changed as long as it matches
> `*[0-9][0-9].*'.)

Here's what I committed instead, after first cleaning up CVS to not
include generated files.  I verified that it tickles the bug if your
November patch is reverted (the first quote character is never pushed
back, so the multi-char push_string_init requires a changequote of 3 or
more characters).  I added your name to THANKS (it was inadvertantly left
out from your November patch), but am not including that patch here since
it includes random email addresses.

2006-05-11  Eric Blake  <address@hidden>

        * THANKS: Update.
        * doc/m4.texinfo (Changequote): Give testsuite exposure to bug
        patched on 2005-12-04.  Reported by Ilya N. Golubev <address@hidden>

- --
Life is short - so eat dessert first!

Eric Blake             address@hidden
Version: GnuPG v1.4.2.1 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

Index: doc/m4.texinfo
RCS file: /sources/m4/m4/doc/m4.texinfo,v
retrieving revision
diff -u -p -r1. m4.texinfo
--- doc/m4.texinfo      11 May 2006 12:56:19 -0000
+++ doc/m4.texinfo      11 May 2006 13:22:50 -0000
@@ -1807,12 +1807,12 @@ If no single character is appropriate, @
 of any length.
-changequote([[, ]])
+changequote([[[, ]]])
-define([[foo]], [[Macro [[[foo]]].]])
+define([[[foo]]], [[[Macro [[[[[foo]]]]].]]])
address@hidden [foo].
address@hidden [[foo]].
 @end example
 Changing the quotes to the empty strings will effectively disable the

reply via email to

[Prev in Thread] Current Thread [Next in Thread]