[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: GNU M4 1.4.8b released (beta release)

From: Eric Blake
Subject: Re: GNU M4 1.4.8b released (beta release)
Date: Sat, 10 Mar 2007 07:53:21 -0700
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20070221 Thunderbird/ Mnenhy/

Hash: SHA1

According to Matthew Woehlke on 3/8/2007 9:28 AM:
> (We already know this doesn't work: if configure doesn't define
> HAVE_LONG_LONG_INT, then the resulting stdint.h breaks system headers.)
> Without also telling gnulib not to use 'long long', we know other things
> (like gnulib's printf - of whichever flavor, I don't recall exactly
> which one offhand) break.
> I did this:
> --- stdint_.h   2007-03-08 08:14:55.000000000 -0800
> +++ ../../m4-1.4.8b-orig/lib/stdint_.h  2007-03-01 08:48:39.000000000 -0800
> @@ -120,17 +120,12 @@
>  #define int32_t int
>  #define uint32_t unsigned int
> +#undef int64_t
>  #if LONG_MAX >> 31 >> 31 == 1
> -# undef int64_t
> -# define GNULIB_int64_t


Your patch was backwards, but since it solved your build, it is worth
committing.  Here's what I'm checking in so that a platforms int64_t is
not overridden if gnulib does not use 64-bit types.  It still does not
solve the issue of whether gnulib should insist that long long and
unsigned long long must both exist with the same width, or claim that
neither is usable; but as yours is the only odd platform encountered so
far, and since CFLAGS=-O appears to solve it for you, I'm not sure how
others feel about trying to improve gnulib in this area.  It may end up
that I release m4 1.4.9 and you have to compile with optimizations on for
it to work on NSK.

2007-03-10  Eric Blake  <address@hidden>
        and Matthew Woehlke  <mw_triad AT users.sourceforge.net>  (tiny change)

        * lib/stdint_.h (int64_t, uint64_t): Don't undefine if 64-bit
        types are not being provided by gnulib.
        (GL_INT64_T, GL_UINT64_T): New witnesses of whether gnulib 64-bit
        types are supported.

- --
Don't work too hard, make some time for fun as well!

Eric Blake             address@hidden
Version: GnuPG v1.4.5 (Cygwin)
Comment: Public key at home.comcast.net/~ericblake/eblake.gpg
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org


reply via email to

[Prev in Thread] Current Thread [Next in Thread]