[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [m17n-list] m17n-lib-1.6.4/src/mtext.c:1844: possible bad if test ?
|
From: |
Kenichi Handa |
|
Subject: |
Re: [m17n-list] m17n-lib-1.6.4/src/mtext.c:1844: possible bad if test ? |
|
Date: |
Mon, 28 Oct 2013 22:37:25 +0900 |
In article <address@hidden>, David Binderman <address@hidden> writes:
> I just compiled the package with extra gcc compiler flag -Wlogical-op.
> It said
> mtext.c:1844:4: warning: logical 'or' of collectively exhaustive tests is
> always true [-Wlogical-op]
> Source code is
> if (p1[0]>= 0xD800 || p1[0] < 0xDC00)
> Suggest swap || for &&
Thank you very much for finding this silly bug. I've just
committed the fix.
---
Kenichi Handa
address@hidden