[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lzip-bug] [PATCH] lzip on Windows

From: JonY
Subject: Re: [Lzip-bug] [PATCH] lzip on Windows
Date: Tue, 13 Oct 2009 20:20:54 +0800
User-agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv: Gecko/20080213 Thunderbird/ Mnenhy/

On 10/13/2009 03:33, Antonio Diaz Diaz wrote:
Dear Jon,

Thank you for the patch, but I'm afraid I can't accept it by a number of

It is too intrusive. I am pretty sure lines like this
snprintf( buf, sizeof buf, "%"LZIPLL"d %s", num, p );
will break compilation on some other systems.

It is for a system too different from posix systems, and there is at
least a way of compiling lzip in windows that does not need to obscure
the code with conditional compilation constructs; Cygwin.


I just found a massive thinko with my previous patches, not sure why it worked at all. In the mean time, I'll still try to find a less intrusive method.

I have to agree, your code does look clean from a POSIX perspective, thanks for your input.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]