Re: [Lynx-dev] SOCK5 crash+fix

[Steffen Nurpmeso]

Gisle Vanem wrote in
 <250c80e1-7697-3981-7f0e-42be642f7cb8@gmail.com>:
 |>> HTSprintf0 expects to have the address of a pointer in which it
 |>> can return a pointer to newly-allocated memory.
 |> 
 |> 'HTSprintf0(NULL,..)' looks okay to me, but crashes
 |> on some condition anyway. Some Runtime-Checks that gets
 |> confused (?).
 |
 |I think I found the cause of it:
 |
 |--- orig/WWW/Library/Implementation/HTString.c 2021-06-09 22:16:06
 |+++ WWW/Library/Implementation/HTString.c      2022-03-11 13:48:17
 |     char *dst_ptr = *pstr;
 |     const char *format = fmt;
 |-   char *dst_ptr = *pstr;      // line 680
 |+   char *dst_ptr = pstr ? *pstr : NULL;

Oh i see.  My bad not having looked deeply into this.
Seems vasprintf stuff is everywhere i go.

 --End of <250c80e1-7697-3981-7f0e-42be642f7cb8@gmail.com>

--steffen
|
|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)