Re: [Lynx-dev] documentation build issue with e.g. -j3

[Thomas Dickey]

On Sun, Feb 28, 2021 at 01:59:02PM -0500, Thomas Dickey wrote:
> On Sun, Feb 28, 2021 at 02:21:15PM +0100, Andreas Metzler wrote:
> > Hello Thomas,
> > 
> > On 2021-02-28 Thomas Dickey <dickey@his.com> wrote:
> > > On Sun, Feb 28, 2021 at 08:20:38AM +0100, Andreas Metzler wrote:
> > > > if lynx is built with -j3 the generated body.html is broken since the
> > > > $(CFG2HTML) target is not supposed to run multiple times in parallel
> > 
> > > ...I did see the comments in Debian #983209
> > 
> > > > Suggested patch:
> > > > -----------
> > > > --- lynx-2.9.0dev.6.orig/makefile.in
> > > > +++ lynx-2.9.0dev.6/makefile.in
> > > > @@ -338,7 +338,7 @@ LYNX_URL='@HOMEPAGE_URL@release/breakout
> > > >  LYNXDOCS_URL='$(LYNX_URL)/docs/'
> > > >  LYNXHELP_URL='$(LYNX_URL)/lynx_help/'
> > > > 
> > > > -@LYNXCFG_MAKE@$(CFG2HTML) :
> > > > +@LYNXCFG_MAKE@$(CFG2HTML) &:
> > >                              ^^
> > 
> > > That looks like a feature specific to GNU make.
> > 
> > Yes, I think so, too.
> 
> :-)
>  
> > > Offhand, Lynx's makefiles will only use POSIX make, adding "::".  If
> > > you really need _that_, it'll have to be as a patch in the Debian
> > > package.
> > [...]
> > 
> > Well, the other straightforward option is disabling parallel make. Do
> > you support parallel make? If you do we will need to find a different
> > fix, OTOH if you do not then disabling parallel build in the Debian
> > package is probably the correct way to deal with the report.
> 
> that's a short-term fix.
> 
> Actually, I've not found a way to reproduce problems with parallel make
> using GNU make.  However, it's fairly simple to reproduce similar problems
> using BSD make (I could digress).  So I had that on a to-do list, anyway.
> At the moment I'm testing a more involved change which fixes this issue
> as reproduced in pmake (along with other fixes), and once done with testing
> that set of changes, will make an update in my git snapshots.

https://github.com/ThomasDickey/lynx-snapshots/commit/f100e91840bc2ef2cecf3d0975b734e53637fa55

-- 
Thomas E. Dickey <dickey@invisible-island.net>
https://invisible-island.net
ftp://ftp.invisible-island.net

signature.asc
Description: PGP signature