Re: [Lynx-dev] SOCKS5_PROXY (was Re: the sun, the sun)

[Steffen Nurpmeso]

Sorry for the late reply, i moved that to +track already and then
quit after working +download, pffh.  Too tired, too sultry, pfff.

Thorsten Glaser wrote in
 <Pine.BSM.4.64L.2008091610240.7264@herc.mirbsd.org>:
 |Turns out you do not even need a magic value. You tried a
 |premature optimisation, but Lynx calls LYGetEnv for the

mumble .. premature .. mumble

Interesting!  I surely grepped getenv(3) .. and found it!
Otherwise i hope i would have found LyGetEnv.

 |other *_proxy variables each time as well, so dropping the
 |premature optimisation and switching to LYGetEnv and fixing
 |a bug in the man(7)page results in:

mumble .. maybe i find it if i rescan .. mumble

 |--- a/WWW/Library/Implementation/HTTCP.c
 |+++ b/WWW/Library/Implementation/HTTCP.c
 |@@ -1848,6 +1848,8 @@ int HTDoConnect(const char *url,
 |     *s = -1;                 /* nothing is open yet */
 | 
 |     /* In case of a present SOCKS5 proxy, marshal */
 |+    if (socks5_proxy == NULL)
 |+     socks5_proxy = LYGetEnv("SOCKS5_PROXY");
 |     if ((socks5_orig_url = socks5_proxy) != NULL) {
 |  int xport;
 | 
 |--- a/lynx.man
 |+++ b/lynx.man
 |@@ -805,9 +805,16 @@ If enabled the transfer rate is shown in bytes/second.
 | If disabled, no transfer rate is shown.
 | Use lynx.cfg or the options menu to select KB/second and/or ETA.
 | .TP
 |-.B \-socks5\-proxy=URL
 |-(Via which) SOCKS5 proxy to connect.
 |-This controls the builtin SOCKS5 support, and is therefore unrelated to
 |+.B \-socks5_proxy=URL
 |+(Via which) SOCKS5 proxy to connect: any network traffic, including all
 |+DNS resolutions but the one for URL itself, will be redirected through
 |+the SOCKS5 proxy.
 |+URL may be given as \*(``proxy.example.com\*('',
 |+\*(``proxy.example.com:1080\*('', \*(``192.168.0.1\*('', or
 |+\*(``192.168.0.1:1080\*('' (and IPv6 notation if so supported).
 |+A SOCKS5 proxy may also be specified via the environment variable
 |+.B SOCKS5_PROXY.
 |+This option controls the builtin SOCKS5 support, which is unrelated to
 | the option \fB\-nosocks\fP.
 | .TP
 | .B \-soft_dquotes
 |@@ -1139,6 +1146,11 @@ wais_proxy
 | .IP
 | See \fBLynx Users Guide\fR for additional details and examples.
 | .TP
 |+.B SOCKS5_PROXY
 |+Is inspected if
 |+.B \-socks5_proxy
 |+has not been used (for the same content).
 |+.TP
 | .B SSL_CERT_DIR
 | Set to the directory containing trusted certificates.
 | .TP
 |--- a/src/LYMain.c
 |+++ b/src/LYMain.c
 |@@ -3916,7 +3916,7 @@ saves session to that file on exit"
 |    ),
 | #endif
 |    PARSE_STR(
 |-      "socks5-proxy",        2|NEED_LYSTRING_ARG,    socks5_proxy,
 |+      "socks5_proxy",        2|NEED_LYSTRING_ARG,    socks5_proxy,
 |       "=URL\n(via which) SOCKS5 proxy to connect (unrelated to -nosocks!)"
 |    ),
 |    PARSE_SET(

Well sure, if it works out like that i will not stand in the way!

--steffen
|
|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)