[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Lynx-dev] Adding $SOCKS5_PROXY support, changing command line optio

From: Steffen Nurpmeso
Subject: Re: [Lynx-dev] Adding $SOCKS5_PROXY support, changing command line option
Date: Sat, 08 Aug 2020 01:25:09 +0200
User-agent: s-nail v14.9.19-100-gd425f9da-dirty


Thorsten Glaser wrote in
 |Steffen Nurpmeso dixit:
 ||+     socks5_proxy = (char*)-1;
 |Don’t do that, that is not portable.

Really??  This i do not understand.

 ||   cleanup:
 ||-    if (socks5_proxy != NULL) {
 ||+    if (socks5_proxy != (char*)-1) {
 ||  FREE(socks5_new_url);
 ||  FREE(socks5_protocol);
 ||  FREE(socks5_host);
 |If this is just for freeing… free(3) takes NULL as no-op.
 |Otherwise, find a better way to flag this.
 |Your patch also changes something wrt. socks5_orig_url.

That is just plain terrible!  What a mess.
Thanks a lot for looking into the patch, Thorsten!

Well, at least this shows i use lynx exclusively via -socks5_proxy
ever since the functionality is there. 
Fixed, and tested with _and_without_ -socks5_proxy. 
(The patch applies to the git snapshot, not the dev5 ball, due to
manual page, the former has the first, the latter the, hmm,

  -.B \-socks5\-proxy=URL
  -.B \-socks5-proxy=URL

Ciao, and a nice weekend.
Good night.

|Der Kragenbaer,                The moon bear,
|der holt sich munter           he cheerfully and one by one
|einen nach dem anderen runter  wa.ks himself off
|(By Robert Gernhardt)

Attachment: lynx-socks5-env.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]