Re: [Lynx-dev] Bug#699068: [larryhsfriends] Fwd: lynx: Cannot Type a Page-Number more than

[Thomas Dickey]

----- Original Message -----
| From: "Thomas Dickey" <address@hidden>
| To: address@hidden
| Cc: address@hidden, "Dallas E. Legan" <address@hidden>, "Thorsten Glaser" 
<address@hidden>
| Sent: Monday, April 6, 2015 5:21:57 AM
| Subject: Bug#699068: [Lynx-dev] [larryhsfriends] Fwd: lynx: Cannot Type a 
Page-Number more than
| 
| ----- Original Message -----
| | From: "Thomas Dickey" <address@hidden>
| | To: "Thorsten Glaser" <address@hidden>, address@hidden
| | Cc: address@hidden, "Dallas E. Legan" <address@hidden>
| | Sent: Monday, April 6, 2015 5:09:57 AM
| | Subject: Bug#699068: [Lynx-dev] [larryhsfriends] Fwd: lynx: Cannot
| | Type a Page-Number more than
| | 
| | ----- Original Message -----
| | | From: "Thorsten Glaser" <address@hidden>
| | | To: "Dallas E. Legan" <address@hidden>
| | | Cc: address@hidden, address@hidden
| | | Sent: Sunday, April 5, 2015 10:24:14 PM
| | | Subject: Bug#699068: [Lynx-dev] [larryhsfriends] Fwd: lynx:
| | | Cannot
| | | Type a Page-Number more than
| | | 
| | | (removing yahoo from the list of recipients, my MTA blocks them
| | | as
| | | spammers)
| | | 
| | | Dallas E. Legan dixit:
| | | 
| | | >To reproduce this:
| | | 
| | | Thanks, that is indeed… weird.
| | | 
| | | >I've done some checking on various machines I have accounts on:
| | | 
| | |    MirBSD-current/i386 machine
| | |   Lynx Version 2.8.8dev.16-MirOS-0AB5.1
| | |   limit 4 chars
| | | 
| | |   Debian unstable/i386 machine
| | |   Lynx Version 2.8.9dev.1 (12 Mar 2014)
| | |   limit 4 chars
| | | 
| | |   Debian unstable/amd64 machine
| | |   same version as above
| | |   limit 8 chars
| | | 
| | | So, WTF? Seems to be related to sizeof(pointer).
| | | 
| | | This looks to me like a classical mistake. I saw something like
| | | this
| | | when such a change was applied to code:
| | | 
| | |  {
| | | - char buf[100];
| | | + char *buf = xmalloc(100);
| | | 
| | |   /* […] */
| | | 
| | |   readinput(buf, sizeof(buf));
| | |  }
| | | 
| | 
| | thanks for the reminder (I'll take a look to review uses of
| | sizeof()...)
| 
| agreed - I see that in src/LYGetFile.c, follow_link_number.
| I'll add this to the po-files updates (after checking the one
| which there was some concern that it was not working correctly).

fwiw, there's a patch including this fix in

    ftp://invisible-island.net/temp/lynx2.8.9dev.4b.patch.gz

(there was some email comment about a problem with one of the translations - 
when
I have some time late this week, I'll put out dev.5)

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net