Re: [Lynx-dev] Lynx Version 2.8.8pre.5 should copy files in share/lynx_doc/ with correct owners/permissions

[Thomas Dickey]

On Sat, Mar 15, 2014 at 11:27:54AM +0800, Rajeev V. Pillai wrote:
> On Sunday, February 23, 2014 5:07 PM, Thomas Dickey <address@hidden> wrote:
> 
> > On Sun, Feb 23, 2014 at 07:58:47AM +0800, Rajeev V. Pillai wrote:
> >
> >> Files and dirs. in share/lynx_doc/ are not installed with the correct
> >> owners/permissions. On a newly installed lynx directory
> >> (user's default umask is 0077):>
> > hmm - the reason for this is the (very old) use of tar for copying that
> > directory.  I vaguely recall it being mentioned several years ago.
> > Most people rely upon packages (which generally are build using umask 027),
> 
> The addition of `umask 022' to the tar commands in `2.8.8rel.2.patch' still
> doesn't set the correct owners+permissions for the files in share/lynx_doc/.
> because the 1st tar cmd. picks up the owners/permissions for those files
> from when the source tarball was extracted--ie. when the umask and user/grp
> could have been anything:

I see.  I had tested this by setting umask in the build process,
but using a pristine tarball (which would have correct permissions).
I did that for both dpkg and rpm...
 
> $ ls -l /opt/lynx/share/lynx_doc
> total 624
> -rw------- 1 root rvp 565304 Mar 10 03:13 CHANGES
> -rw------- 1 root rvp   3381 Jan 12 00:36 COPYHEADER
> -rw------- 1 root rvp    267 Jan 12 00:36 COPYHEADER.asc
> -rw------- 1 root rvp  18156 Oct 11  2006 COPYING
> -rw------- 1 root rvp    258 Oct 11  2006 COPYING.asc
> drwx------ 2 root rvp   4096 Mar 15 08:19 docs
> -rw------- 1 root rvp  11922 May 24  2004 PROBLEMS
> -rw------- 1 root rvp   6829 Feb 14 18:30 README
> drwx------ 2 root rvp   4096 Mar 15 08:19 samples
> drwx------ 2 root rvp   4096 Mar 15 08:19 test
> 
> What's needed, is to change this line in the install-doc rule in 
> `makefile.in':
> 
> -$(SHELL) -c 'case `id|sed -e "s/(.*//"` in uid=0) chown -R root $(DOCDIR);; 
> esac'
> 
> to this:
> 
> -$(SHELL) -c 'case `id|sed -e "s/(.*//"` in uid=0) chown -R root.root 
> $(DOCDIR);; esac'
> 
> and add a couple of additional commands in there--something along the lines 
> of:
> 
> find $(DOCDIR) -type d -print0 | xargs -0 chmod 755
> find $(DOCDIR) -type f -print0 | xargs -0 chmod 644

something like (but not exactly: the example given isn't portable)

thanks

-- 
Thomas E. Dickey <address@hidden>
http://invisible-island.net
ftp://invisible-island.net

signature.asc
Description: Digital signature