Re: [Lynx-dev] 2.8.6dev.10 crashes

[Thomas Dickey]

On Wed, 5 Jan 2005, Elimar Riesebieter wrote:

> On Wed, 05 Jan 2005 the mental interface of
> Thorsten Glaser told:
>
> > Fr?d?ric L. W. Meunier dixit:
> >
> > > At http://www.soccerway.com/results/browsecompetitions.php when I press '\' to
> > > see the source.
> >
> > Thanks Fr?d?ric, this is _exactly_ my problem, just you made
> > it reproducible!
> Can't reproduce.......

It doesn't break all the time, but valgrind reports a problem there.
The fix is this (I don't see any other occurrences of this one):

# ------------------------------------------------------------------------------
# GridText.c |    5 +----
# 1 files changed, 1 insertion(+), 4 deletions(-)
# ------------------------------------------------------------------------------
Index: src/GridText.c
--- lynx2.8.6dev.10+/src/GridText.c     2005-01-02 23:49:58.000000000 +0000
+++ lynx2.8.6dev.10a/src/GridText.c     2005-01-05 02:36:50.000000000 +0000
@@ -8860,10 +8860,7 @@
     if ((dest = HTAnchor_followLink(textanchor->anchor)) &&
        (text->hiddenlinkflag != HIDDENLINKS_IGNORE ||
         HTList_isEmpty(text->hidden_links))) {
-       char *cp_freeme = NULL;
-
-       HTList_appendObject(text->hidden_links, cp_freeme = 
HTAnchor_address(dest));
-       FREE(cp_freeme);
+       HTList_appendObject(text->hidden_links, HTAnchor_address(dest));
     }

     return;



--
Thomas E. Dickey
http://invisible-island.net
ftp://invisible-island.net