Re: [Lynx-dev] Re: weird abortions

[Thorsten Glaser]

Thomas Dickey dixit:

>> Hm, strlcpy and truncation detection, or so?
>
>something like that (but strlcpy isn't portable).

You could package it, like I do with the portable version of
our ksh derivate.

A combined .c file (optimised against the original OpenBSD
version) weighs 4255 bytes, including #ifdev HAVE_STRLCPY
and #ifdef HAVE_STRLCAT checks as well as HAVE_CONFIG_H.

>lynx has its own functions.  But with 170,000 lines of source code (50,000
>statements), it's possible to overlook the bad usage of fixed buffers among the
>good ones.  Bear in mind that lynx has been audited by several different people
>(and old bugs are occasionally found - proving that auditing doesn't find all
>of the bugs).

I sure understand that. (You don't want to see AT&T derived
4.4BSD nroff source either.)

>I'll spend some time with valgrind, see if I can make dev.10 crash.
>The nice thing about valgrind is that I don't have to recompile the
>application to find problems (though for analysis, a debug-image is
>needed).

Ah, nice. I'll look into that tomorrow or so then.

gn8,
//mirabile